mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-21 16:18:55 +00:00
_make_tui_argv() called _ensure_tui_workspace(tui_dir) unconditionally before checking for a prebuilt bundle. That function sys.exit(1)s when ui-tui/ doesn't exist, which it never does on a pip/pipx install — the wheel ships hermes_cli/tui_dist/entry.js but never ships ui-tui/ at all (that directory only exists in a git checkout). Every dashboard Chat tab connection on a pip/pipx install therefore hard-exited before ever reaching _find_bundled_tui(), surfacing as the unhelpful "Chat unavailable: 1" banner despite having a fully valid bundled entry.js on disk. Move the bundled-wheel/HERMES_TUI_DIR shortcut ahead of the workspace check. --dev is unaffected (it never uses the bundled path and still requires the workspace), and the checkout-without-bundle path is unaffected (bundled lookup returns None, falls through to the existing git-restore/npm-install/build flow). Adds a contributors/emails mapping for the original author. Fixes #56665 Co-authored-by: lucaskvasirr <lucaskvasir@duck.com> |
||
|---|---|---|
| .. | ||
| emails | ||
| README.md | ||
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.