mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
74 lines
2.4 KiB
Python
74 lines
2.4 KiB
Python
import json
|
|
from types import SimpleNamespace
|
|
|
|
|
|
def test_postprocess_adds_agent_visible_image_for_active_ssh_env(monkeypatch, tmp_path):
|
|
from tools import image_generation_tool
|
|
|
|
hermes_home = tmp_path / ".hermes"
|
|
image_dir = hermes_home / "cache" / "images"
|
|
image_dir.mkdir(parents=True)
|
|
image_path = image_dir / "xai_grok-imagine-image_test.jpg"
|
|
image_path.write_bytes(b"jpg")
|
|
|
|
sync_calls = []
|
|
|
|
class FakeSyncManager:
|
|
def sync(self, *, force=False):
|
|
sync_calls.append(force)
|
|
|
|
env = SimpleNamespace(
|
|
_remote_home="/home/remotesshuser",
|
|
_sync_manager=FakeSyncManager(),
|
|
)
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
monkeypatch.setattr(image_generation_tool, "_active_terminal_env", lambda task_id: env)
|
|
|
|
raw = json.dumps({"success": True, "image": str(image_path)})
|
|
result = json.loads(
|
|
image_generation_tool._postprocess_image_generate_result(raw, task_id="task-1")
|
|
)
|
|
|
|
assert result["image"] == str(image_path)
|
|
assert result["host_image"] == str(image_path)
|
|
assert result["agent_visible_image"] == (
|
|
"/home/remotesshuser/.hermes/cache/images/xai_grok-imagine-image_test.jpg"
|
|
)
|
|
assert sync_calls == [True]
|
|
|
|
|
|
def test_handle_image_generate_postprocesses_plugin_result(monkeypatch, tmp_path):
|
|
from tools import image_generation_tool
|
|
|
|
hermes_home = tmp_path / ".hermes"
|
|
image_dir = hermes_home / "cache" / "images"
|
|
image_dir.mkdir(parents=True)
|
|
image_path = image_dir / "plugin.png"
|
|
image_path.write_bytes(b"png")
|
|
|
|
env = SimpleNamespace(_remote_home="/home/remote", _sync_manager=None)
|
|
|
|
seen_task_ids = []
|
|
|
|
def fake_active_env(task_id):
|
|
seen_task_ids.append(task_id)
|
|
return env
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
monkeypatch.setattr(image_generation_tool, "_active_terminal_env", fake_active_env)
|
|
monkeypatch.setattr(
|
|
image_generation_tool,
|
|
"_dispatch_to_plugin_provider",
|
|
lambda prompt, aspect_ratio, **kw: json.dumps({"success": True, "image": str(image_path)}),
|
|
)
|
|
|
|
result = json.loads(
|
|
image_generation_tool._handle_image_generate(
|
|
{"prompt": "draw", "aspect_ratio": "square"},
|
|
task_id="plugin-task",
|
|
)
|
|
)
|
|
|
|
assert seen_task_ids == ["plugin-task"]
|
|
assert result["agent_visible_image"] == "/home/remote/.hermes/cache/images/plugin.png"
|