mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-01 12:02:05 +00:00
109 lines
4.3 KiB
Python
109 lines
4.3 KiB
Python
"""Regression tests for the _get_command_timeout cache race (#14331).
|
|
|
|
Before the fix:
|
|
``_command_timeout_resolved`` was set to ``True`` *before*
|
|
``_cached_command_timeout`` was assigned. If the body raised between those
|
|
two statements (e.g. inside ``read_raw_config``), or a re-entrant/concurrent
|
|
reader hit the cache between them, the function returned ``None``. Callers
|
|
then evaluated ``max(None, 60)`` and crashed with::
|
|
|
|
TypeError: '>' not supported between instances of 'int' and 'NoneType'
|
|
|
|
The fix:
|
|
1. assign cache before flipping the resolved flag,
|
|
2. flip the resolved flag *off* before nulling the cache in
|
|
``cleanup_all_browsers()``,
|
|
3. expose ``_safe_command_timeout()`` as defense in depth.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
|
|
class TestGetCommandTimeoutRace:
|
|
def setup_method(self):
|
|
from tools import browser_tool
|
|
|
|
self.bt = browser_tool
|
|
self._orig_cache = browser_tool._cached_command_timeout
|
|
self._orig_resolved = browser_tool._command_timeout_resolved
|
|
browser_tool._cached_command_timeout = None
|
|
browser_tool._command_timeout_resolved = False
|
|
|
|
def teardown_method(self):
|
|
self.bt._cached_command_timeout = self._orig_cache
|
|
self.bt._command_timeout_resolved = self._orig_resolved
|
|
|
|
def test_returns_default_when_config_read_raises(self):
|
|
"""If config reading blows up, we still return an int (not None)."""
|
|
with patch(
|
|
"hermes_cli.config.read_raw_config", side_effect=RuntimeError("boom")
|
|
):
|
|
result = self.bt._get_command_timeout()
|
|
|
|
assert isinstance(result, int)
|
|
assert result == self.bt.DEFAULT_COMMAND_TIMEOUT
|
|
# Cache must be populated (not left as None) once resolved is True.
|
|
assert self.bt._cached_command_timeout is not None
|
|
assert self.bt._command_timeout_resolved is True
|
|
|
|
def test_cache_assigned_before_resolved_flag(self):
|
|
"""Invariant: if resolved=True then cache must not be None."""
|
|
with patch(
|
|
"hermes_cli.config.read_raw_config", side_effect=RuntimeError("boom")
|
|
):
|
|
self.bt._get_command_timeout()
|
|
|
|
# The bug was: resolved=True while cache=None. Assert that's impossible.
|
|
assert not (
|
|
self.bt._command_timeout_resolved
|
|
and self.bt._cached_command_timeout is None
|
|
)
|
|
|
|
def test_safe_command_timeout_never_returns_none(self):
|
|
"""Defense-in-depth helper survives a manually corrupted cache."""
|
|
# Simulate the pre-fix bug state directly.
|
|
self.bt._command_timeout_resolved = True
|
|
self.bt._cached_command_timeout = None
|
|
|
|
result = self.bt._safe_command_timeout()
|
|
assert isinstance(result, int)
|
|
assert result == self.bt.DEFAULT_COMMAND_TIMEOUT
|
|
|
|
def test_safe_command_timeout_preserves_zero(self):
|
|
"""``or DEFAULT_COMMAND_TIMEOUT`` would swallow a legit 0.
|
|
|
|
We use ``is not None`` so a configured 0 stays 0. (In practice the
|
|
caller floor is 5s, but the helper itself must be honest.)
|
|
"""
|
|
self.bt._command_timeout_resolved = True
|
|
self.bt._cached_command_timeout = 0
|
|
|
|
assert self.bt._safe_command_timeout() == 0
|
|
|
|
def test_cleanup_resets_flag_before_nulling_cache(self):
|
|
"""After cleanup, observers must never see resolved=True with cache=None."""
|
|
# Warm the cache first.
|
|
with patch(
|
|
"hermes_cli.config.read_raw_config", side_effect=RuntimeError("boom")
|
|
):
|
|
self.bt._get_command_timeout()
|
|
assert self.bt._command_timeout_resolved is True
|
|
|
|
self.bt.cleanup_all_browsers()
|
|
|
|
# Post-cleanup: both must be reset together; specifically resolved must
|
|
# not be True while cache is None (the original race window).
|
|
assert not (
|
|
self.bt._command_timeout_resolved
|
|
and self.bt._cached_command_timeout is None
|
|
)
|
|
|
|
def test_max_call_site_pattern_never_raises(self):
|
|
"""The exact expression from browser_navigate must not raise TypeError."""
|
|
# Force the corrupted state the bug used to produce.
|
|
self.bt._command_timeout_resolved = True
|
|
self.bt._cached_command_timeout = None
|
|
|
|
# This is the literal line from browser_navigate() after the fix.
|
|
timeout = max(self.bt._safe_command_timeout(), 60)
|
|
assert timeout == 60
|