mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-05 07:41:39 +00:00
44b63fc6de
When an approval / clarify / confirm overlay was active, the global input
handler in useInputHandlers returned for every key that wasn't Ctrl+C, which
silently disabled transcript scrolling. On long threads the context the
prompt was asking about often lived above the visible viewport, and being
unable to scroll while answering felt like the prompt had locked the UI.
ApprovalPrompt also had no Esc handler at all, so the one obvious 'abort'
key did nothing during a permission prompt and the user had to memorize
Ctrl+C or hunt for the deny number.
Fixes:
- Extract shouldFallThroughForScroll(key) (pure, exported) covering wheel
scrolls, PageUp/PageDown, and Shift+ArrowUp/Down. When a prompt overlay
is up and the pressed key is a scroll input, skip the early return so it
reaches the existing wheel/PageUp/Shift+arrow handlers below. Plain
arrows still drive in-prompt selection — they don't fall through.
- ApprovalPrompt now maps Esc to onChoice('deny'), parity with the global
Ctrl+C cancellation path that already invokes cancelOverlayFromCtrlC()
for approvals. The bottom-of-prompt hint now advertises 'Esc/Ctrl+C deny'.
- Extract approvalAction(ch, key, sel) — pure key-dispatch helper for the
approval prompt, exported so the regression matrix (Esc, numbers, Enter,
arrows, edge clamping, precedence) is testable without mounting Ink.
Tests:
- useInputHandlers.test.ts: 6 cases covering shouldFallThroughForScroll
positives (wheel/PageUp/PageDown/Shift+arrows) and negatives (plain
arrows, bare shift, no scroll key).
- approvalAction.test.ts: 8 cases covering Esc→deny, numeric mapping,
Enter, ↑↓ within bounds, edge clamping, Esc-beats-others precedence,
unrelated keystrokes.
77 lines
2.8 KiB
TypeScript
77 lines
2.8 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest'
|
|
|
|
import { applyVoiceRecordResponse, shouldFallThroughForScroll } from '../app/useInputHandlers.js'
|
|
|
|
const baseKey = {
|
|
downArrow: false,
|
|
pageDown: false,
|
|
pageUp: false,
|
|
shift: false,
|
|
upArrow: false,
|
|
wheelDown: false,
|
|
wheelUp: false
|
|
}
|
|
|
|
describe('shouldFallThroughForScroll — keep transcript scrolling alive during prompt overlays', () => {
|
|
it('falls through for wheel scrolls', () => {
|
|
expect(shouldFallThroughForScroll({ ...baseKey, wheelUp: true })).toBe(true)
|
|
expect(shouldFallThroughForScroll({ ...baseKey, wheelDown: true })).toBe(true)
|
|
})
|
|
|
|
it('falls through for PageUp / PageDown', () => {
|
|
expect(shouldFallThroughForScroll({ ...baseKey, pageUp: true })).toBe(true)
|
|
expect(shouldFallThroughForScroll({ ...baseKey, pageDown: true })).toBe(true)
|
|
})
|
|
|
|
it('falls through for Shift+ArrowUp / Shift+ArrowDown', () => {
|
|
expect(shouldFallThroughForScroll({ ...baseKey, shift: true, upArrow: true })).toBe(true)
|
|
expect(shouldFallThroughForScroll({ ...baseKey, shift: true, downArrow: true })).toBe(true)
|
|
})
|
|
|
|
it('does NOT fall through for plain arrows — those drive in-prompt selection', () => {
|
|
expect(shouldFallThroughForScroll({ ...baseKey, upArrow: true })).toBe(false)
|
|
expect(shouldFallThroughForScroll({ ...baseKey, downArrow: true })).toBe(false)
|
|
})
|
|
|
|
it('does NOT fall through for plain Shift — without an arrow it is a no-op', () => {
|
|
expect(shouldFallThroughForScroll({ ...baseKey, shift: true })).toBe(false)
|
|
})
|
|
|
|
it('does NOT fall through for unrelated state (no scroll keys held)', () => {
|
|
expect(shouldFallThroughForScroll(baseKey)).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('applyVoiceRecordResponse', () => {
|
|
it('reverts optimistic REC state when the gateway reports voice busy', () => {
|
|
const setProcessing = vi.fn()
|
|
const setRecording = vi.fn()
|
|
const sys = vi.fn()
|
|
|
|
applyVoiceRecordResponse({ status: 'busy' }, true, { setProcessing, setRecording }, sys)
|
|
|
|
expect(setRecording).toHaveBeenCalledWith(false)
|
|
expect(setProcessing).toHaveBeenCalledWith(true)
|
|
expect(sys).toHaveBeenCalledWith('voice: still transcribing; try again shortly')
|
|
})
|
|
|
|
it('keeps optimistic REC state for successful recording starts', () => {
|
|
const setProcessing = vi.fn()
|
|
const setRecording = vi.fn()
|
|
|
|
applyVoiceRecordResponse({ status: 'recording' }, true, { setProcessing, setRecording }, vi.fn())
|
|
|
|
expect(setRecording).not.toHaveBeenCalled()
|
|
expect(setProcessing).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('reverts optimistic REC state when the gateway returns null', () => {
|
|
const setProcessing = vi.fn()
|
|
const setRecording = vi.fn()
|
|
|
|
applyVoiceRecordResponse(null, true, { setProcessing, setRecording }, vi.fn())
|
|
|
|
expect(setRecording).toHaveBeenCalledWith(false)
|
|
expect(setProcessing).toHaveBeenCalledWith(false)
|
|
})
|
|
})
|