mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
52 lines
1.5 KiB
Python
52 lines
1.5 KiB
Python
"""Tests for cli._prepend_note_to_message.
|
|
|
|
Regression coverage for the TypeError raised when a queued /model or
|
|
/reload-skills note was prepended to a multimodal (image-attached) message:
|
|
``can only concatenate str (not "list") to str``.
|
|
"""
|
|
|
|
from cli import _prepend_note_to_message
|
|
|
|
|
|
def test_string_message_gets_note_prepended():
|
|
assert _prepend_note_to_message("hello", "NOTE") == "NOTE\n\nhello"
|
|
|
|
|
|
|
|
|
|
def test_note_is_stripped():
|
|
assert _prepend_note_to_message("hello", " NOTE ") == "NOTE\n\nhello"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_list_message_folds_note_into_first_text_part():
|
|
message = [
|
|
{"type": "text", "text": "describe this"},
|
|
{"type": "image_url", "image_url": {"url": "data:..."}},
|
|
]
|
|
result = _prepend_note_to_message(message, "NOTE")
|
|
|
|
assert result[0]["type"] == "text"
|
|
assert result[0]["text"] == "NOTE\n\ndescribe this"
|
|
# Image part is preserved untouched.
|
|
assert result[1] == {"type": "image_url", "image_url": {"url": "data:..."}}
|
|
# Original message is not mutated.
|
|
assert message[0]["text"] == "describe this"
|
|
|
|
|
|
def test_image_only_list_gets_leading_text_part():
|
|
message = [{"type": "image_url", "image_url": {"url": "data:..."}}]
|
|
result = _prepend_note_to_message(message, "NOTE")
|
|
|
|
assert result[0] == {"type": "text", "text": "NOTE"}
|
|
assert result[1]["type"] == "image_url"
|
|
|
|
|
|
|
|
|
|
def test_unknown_shape_returned_unchanged():
|
|
assert _prepend_note_to_message(123, "NOTE") == 123
|
|
assert _prepend_note_to_message(None, "NOTE") is None
|