mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
48 lines
1.2 KiB
Python
48 lines
1.2 KiB
Python
"""Tests for malformed proxy env var and base URL validation.
|
|
|
|
Salvaged from PR #6403 by MestreY0d4-Uninter — validates that the agent
|
|
surfaces clear errors instead of cryptic httpx ``Invalid port`` exceptions
|
|
when proxy env vars or custom endpoint URLs are malformed.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
|
|
import pytest
|
|
|
|
from agent.auxiliary_client import _validate_base_url, _validate_proxy_env_urls
|
|
|
|
|
|
# -- proxy env validation ------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize("key", [
|
|
"HTTP_PROXY", "HTTPS_PROXY", "ALL_PROXY",
|
|
"http_proxy", "https_proxy", "all_proxy",
|
|
])
|
|
def test_proxy_env_rejects_malformed_port(monkeypatch, key):
|
|
monkeypatch.setenv(key, "http://127.0.0.1:6153export")
|
|
with pytest.raises(RuntimeError, match=rf"Malformed proxy environment variable {key}=.*6153export"):
|
|
_validate_proxy_env_urls()
|
|
|
|
|
|
# -- base URL validation -------------------------------------------------
|
|
|
|
|
|
@pytest.mark.parametrize("url", [
|
|
"https://api.example.com/v1",
|
|
"http://127.0.0.1:6153/v1",
|
|
"acp://copilot",
|
|
"",
|
|
None,
|
|
])
|
|
def test_base_url_accepts_valid(url):
|
|
_validate_base_url(url) # should not raise
|
|
|
|
|