mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
57 lines
2 KiB
Python
57 lines
2 KiB
Python
"""Regression guard: auxiliary OpenAI clients must use env-only proxy policy.
|
|
|
|
On macOS, httpx with default ``trust_env=True`` reads system proxy settings
|
|
via ``urllib.request.getproxies()`` but not the macOS proxy exception list.
|
|
Auxiliary clients (vision, title generation, etc.) must mirror the main
|
|
agent: explicit ``HTTPS_PROXY`` / ``NO_PROXY`` env vars only, via a custom
|
|
keepalive transport that suppresses automatic system-proxy detection.
|
|
"""
|
|
from unittest.mock import patch
|
|
|
|
import httpx
|
|
|
|
from agent.auxiliary_client import _create_openai_client, _openai_http_client_kwargs
|
|
from agent.process_bootstrap import _get_proxy_for_base_url
|
|
|
|
|
|
def _pool_types(http_client) -> list:
|
|
return [
|
|
type(mount._pool).__name__
|
|
for mount in http_client._mounts.values()
|
|
if mount is not None and hasattr(mount, "_pool")
|
|
]
|
|
|
|
|
|
@patch("agent.auxiliary_client.OpenAI")
|
|
def test_create_openai_client_routes_via_env_proxy(mock_openai, monkeypatch):
|
|
for key in ("HTTPS_PROXY", "HTTP_PROXY", "ALL_PROXY",
|
|
"https_proxy", "http_proxy", "all_proxy", "NO_PROXY", "no_proxy"):
|
|
monkeypatch.delenv(key, raising=False)
|
|
monkeypatch.setenv("HTTPS_PROXY", "http://127.0.0.1:7897")
|
|
|
|
_create_openai_client(
|
|
api_key="test-key",
|
|
base_url="https://litellm.internal.example.com/v1",
|
|
)
|
|
|
|
http_client = mock_openai.call_args.kwargs.get("http_client")
|
|
assert isinstance(http_client, httpx.Client)
|
|
assert "HTTPProxy" in _pool_types(http_client)
|
|
http_client.close()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_proxy_for_base_url_respects_no_proxy(monkeypatch):
|
|
for key in ("HTTPS_PROXY", "HTTP_PROXY", "ALL_PROXY",
|
|
"https_proxy", "http_proxy", "all_proxy", "NO_PROXY", "no_proxy"):
|
|
monkeypatch.delenv(key, raising=False)
|
|
monkeypatch.setenv("HTTPS_PROXY", "http://127.0.0.1:7897")
|
|
monkeypatch.setenv("NO_PROXY", "internal.example.com")
|
|
|
|
assert _get_proxy_for_base_url("https://litellm.internal.example.com/v1") is None
|
|
assert _get_proxy_for_base_url("https://api.openai.com/v1") == "http://127.0.0.1:7897"
|
|
|
|
|