mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
142 lines
3.9 KiB
Python
142 lines
3.9 KiB
Python
"""Tests for the LSP protocol framing layer.
|
|
|
|
The framer is small but load-bearing — Content-Length parsing is the
|
|
single most common reason for hand-rolled LSP clients to silently
|
|
deadlock. These tests exercise:
|
|
|
|
- exact wire format of outgoing messages (encode_message)
|
|
- partial-read tolerance + EOF handling (read_message)
|
|
- envelope helpers (request, response, notification, error)
|
|
- message classification
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import json
|
|
import pytest
|
|
|
|
from agent.lsp.protocol import (
|
|
ERROR_CONTENT_MODIFIED,
|
|
ERROR_METHOD_NOT_FOUND,
|
|
LSPProtocolError,
|
|
LSPRequestError,
|
|
classify_message,
|
|
encode_message,
|
|
make_error_response,
|
|
make_notification,
|
|
make_request,
|
|
make_response,
|
|
read_message,
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# encode_message
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_encode_message_uses_compact_separators_and_utf8():
|
|
msg = {"jsonrpc": "2.0", "id": 1, "method": "x", "params": {"k": "ä"}}
|
|
out = encode_message(msg)
|
|
# Header is plain ASCII Content-Length CRLF CRLF
|
|
header_end = out.index(b"\r\n\r\n") + 4
|
|
header = out[:header_end].decode("ascii")
|
|
body = out[header_end:]
|
|
assert "Content-Length:" in header
|
|
declared = int(header.split("Content-Length:")[1].split("\r\n")[0].strip())
|
|
# Declared length must equal actual body bytes.
|
|
assert declared == len(body)
|
|
# Body parses as JSON and round-trips.
|
|
parsed = json.loads(body.decode("utf-8"))
|
|
assert parsed == msg
|
|
# Body uses compact separators (no spaces between kv).
|
|
assert b'"id":1' in body
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# read_message
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
async def _stream_from_bytes(data: bytes) -> asyncio.StreamReader:
|
|
"""Build an asyncio.StreamReader pre-populated with ``data``."""
|
|
reader = asyncio.StreamReader()
|
|
reader.feed_data(data)
|
|
reader.feed_eof()
|
|
return reader
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_read_message_rejects_runaway_header():
|
|
"""A pathological server that streams headers without ever emitting
|
|
the CRLF-CRLF terminator must not loop forever — the 8 KiB cap kicks
|
|
in and surfaces a protocol error."""
|
|
flood = (b"X-Junk: " + b"A" * 200 + b"\r\n") * 60 # ~12 KiB worth
|
|
reader = await _stream_from_bytes(flood)
|
|
with pytest.raises(LSPProtocolError) as exc:
|
|
await read_message(reader)
|
|
assert "8 KiB" in str(exc.value)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# envelope helpers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_make_notification_omits_id():
|
|
msg = make_notification("log", {"line": "hi"})
|
|
assert "id" not in msg
|
|
assert msg["method"] == "log"
|
|
|
|
|
|
|
|
|
|
def test_make_error_response_shape():
|
|
msg = make_error_response(7, ERROR_CONTENT_MODIFIED, "stale", {"hint": "retry"})
|
|
assert msg["error"]["code"] == ERROR_CONTENT_MODIFIED
|
|
assert msg["error"]["message"] == "stale"
|
|
assert msg["error"]["data"] == {"hint": "retry"}
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# classify_message
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_classify_message_invalid():
|
|
assert classify_message({"id": 1})[0] == "invalid"
|
|
assert classify_message({"jsonrpc": "1.0", "method": "x"})[0] == "invalid"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# LSPRequestError
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_lsp_request_error_carries_code_and_data():
|
|
e = LSPRequestError(ERROR_METHOD_NOT_FOUND, "no", {"x": 1})
|
|
assert e.code == ERROR_METHOD_NOT_FOUND
|
|
assert e.message == "no"
|
|
assert e.data == {"x": 1}
|