mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-09 13:21:42 +00:00
19d4174454
Gateway users can now search resumable sessions from messaging surfaces: /sessions search <query> (alias: find) matches titles and session ids — including every title/id in a row's forward compression chain, so a compressed-away title still surfaces its live tip — plus a punctuation-normalized variant so 'an94' matches 'AN-94'. Implemented by generalizing the existing id_query chain-filter in SessionDB.list_sessions_rich into a combined SQL-level filter (search stays ORDER BY last-active + LIMIT at SQL level), threading a search_query through the shared query_session_listing helper, and teaching parse_session_listing_args to split off a search query. Search results pass through the existing _resume_row_visible guard unchanged: origin scoping, admin-only 'all', and the fail-closed legacy-row posture from the July 1 hardening are preserved exactly. Over-fetch (50) before the visibility cut so origin-invisible matches can't starve the page. Salvages the feature direction of PR #57595 by @GodsBoy with a minimal implementation that keeps the resume authorization surface untouched.
99 lines
4 KiB
Python
99 lines
4 KiB
Python
"""Tests for the shared session-listing helpers (hermes_cli/session_listing.py)."""
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.session_listing import (
|
|
parse_session_listing_args,
|
|
query_session_listing,
|
|
)
|
|
|
|
|
|
class TestParseSessionListingArgs:
|
|
def test_plain_listing(self):
|
|
assert parse_session_listing_args("") == (False, False, "", None)
|
|
|
|
def test_flags(self):
|
|
assert parse_session_listing_args("all full") == (True, True, "", None)
|
|
|
|
def test_target_passthrough(self):
|
|
assert parse_session_listing_args("My Cool Session") == (
|
|
False, False, "My Cool Session", None,
|
|
)
|
|
|
|
def test_search_query(self):
|
|
assert parse_session_listing_args("search an94") == (False, False, "", "an94")
|
|
|
|
def test_find_alias_multiword(self):
|
|
assert parse_session_listing_args("find winton email") == (
|
|
False, False, "", "winton email",
|
|
)
|
|
|
|
def test_all_search(self):
|
|
assert parse_session_listing_args("all search cod") == (True, False, "", "cod")
|
|
|
|
def test_search_without_query_is_empty_string(self):
|
|
assert parse_session_listing_args("search") == (False, False, "", "")
|
|
|
|
def test_search_word_inside_target_is_not_a_flag(self):
|
|
# Flags/keywords only apply before the first positional word.
|
|
assert parse_session_listing_args("deep search notes") == (
|
|
False, False, "deep search notes", None,
|
|
)
|
|
|
|
|
|
class TestQuerySessionListingSearch:
|
|
@pytest.fixture
|
|
def db(self, tmp_path):
|
|
from hermes_state import SessionDB
|
|
db = SessionDB(db_path=tmp_path / "state.db")
|
|
db.create_session("sess_an94", "telegram", user_id="1", chat_id="2")
|
|
db.set_session_title("sess_an94", "AN-94 Prestige Barrel Build #2")
|
|
db.create_session("sess_winton", "whatsapp", user_id="1", chat_id="2")
|
|
db.set_session_title("sess_winton", "Winton Email Sheet Update #3")
|
|
db.create_session("sess_untitled", "telegram", user_id="1", chat_id="2")
|
|
yield db
|
|
db.close()
|
|
|
|
def _ids(self, db, **kw):
|
|
return [r["id"] for r in query_session_listing(db, **kw)]
|
|
|
|
def test_title_substring_match(self, db):
|
|
assert self._ids(db, source="telegram", search_query="prestige") == ["sess_an94"]
|
|
|
|
def test_punctuation_normalized_match(self, db):
|
|
# "an94" should match the title "AN-94 ..." via compact matching.
|
|
assert self._ids(db, source="telegram", search_query="an94") == ["sess_an94"]
|
|
|
|
def test_id_substring_match_includes_unnamed(self, db):
|
|
assert self._ids(db, source="telegram", search_query="untitled") == ["sess_untitled"]
|
|
|
|
def test_source_scoping(self, db):
|
|
assert self._ids(db, source="telegram", search_query="winton") == []
|
|
assert self._ids(db, source="whatsapp", search_query="winton") == ["sess_winton"]
|
|
|
|
def test_no_match(self, db):
|
|
assert self._ids(db, source="telegram", search_query="zzz-nope") == []
|
|
|
|
def test_like_wildcards_are_literal(self, db):
|
|
assert self._ids(db, source="telegram", search_query="%") == []
|
|
|
|
def test_search_matches_compression_root_title(self, tmp_path):
|
|
"""Searching an old (compressed-away) title surfaces the live tip."""
|
|
from hermes_state import SessionDB
|
|
db = SessionDB(db_path=tmp_path / "chain.db")
|
|
db.create_session("root_1", "telegram", user_id="1", chat_id="2")
|
|
db.set_session_title("root_1", "Old Chat")
|
|
db.end_session("root_1", end_reason="compression")
|
|
db.create_session(
|
|
"tip_1", "telegram", user_id="1", chat_id="2", parent_session_id="root_1"
|
|
)
|
|
db.set_session_title("tip_1", "AN-94 Build")
|
|
try:
|
|
for query in ("old chat", "root_1", "an94"):
|
|
rows = query_session_listing(db, source="telegram", search_query=query)
|
|
assert [r["id"] for r in rows] == ["tip_1"], query
|
|
finally:
|
|
db.close()
|
|
|
|
def test_plain_listing_still_hides_unnamed(self, db):
|
|
assert self._ids(db, source="telegram") == ["sess_an94"]
|