mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-22 16:25:58 +00:00
59787b9ada
Two turns interleaving on one session corrupt the durable transcript: flushes race (user rows persist out of arrival order), the identity-marker dedup over shared history dicts can swallow a row, and the second turn runs on a history base that never saw the first turn's exchange. The dispatch route that lets the second turn through the busy guard is not yet identified. Add note_turn_start (build_turn_context) / note_turn_persisted (_persist_session funnel): one WARNING naming both turn_ids when a turn starts before the previous turn's turn-end persist. Ownership transfer keeps a crashed turn from warning more than once; the unconditional clear makes the tripwire under-report rather than double-report under a real overlap. Log-only, no behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
58 lines
2.3 KiB
Python
58 lines
2.3 KiB
Python
"""note_turn_start / note_turn_persisted — the concurrent-turn tripwire.
|
|
|
|
Two turns interleaving on one session corrupt the durable transcript (flush
|
|
order races, identity-dedup row loss, stale history base). The tripwire does
|
|
not prevent the overlap; it names the occurrence with both turn ids so the
|
|
dispatch route that bypassed the busy guard can be identified from logs.
|
|
"""
|
|
|
|
import logging
|
|
|
|
from agent.agent_runtime_helpers import note_turn_start, note_turn_persisted
|
|
|
|
|
|
class _FakeAgent:
|
|
session_id = "s1"
|
|
|
|
|
|
def test_clean_serial_turns_no_warning(caplog):
|
|
agent = _FakeAgent()
|
|
with caplog.at_level(logging.WARNING, logger="agent.agent_runtime_helpers"):
|
|
assert note_turn_start(agent, "s1:t1:aaaa") is None
|
|
note_turn_persisted(agent)
|
|
assert note_turn_start(agent, "s1:t2:bbbb") is None
|
|
note_turn_persisted(agent)
|
|
assert not caplog.records
|
|
|
|
|
|
def test_overlap_warns_with_both_turn_ids(caplog):
|
|
agent = _FakeAgent()
|
|
with caplog.at_level(logging.WARNING, logger="agent.agent_runtime_helpers"):
|
|
note_turn_start(agent, "s1:t1:aaaa")
|
|
# second turn starts before the first persisted
|
|
prev = note_turn_start(agent, "s1:t2:bbbb")
|
|
assert prev == "s1:t1:aaaa"
|
|
assert len(caplog.records) == 1
|
|
msg = caplog.records[0].getMessage()
|
|
assert "s1:t1:aaaa" in msg and "s1:t2:bbbb" in msg and "s1" in msg
|
|
|
|
|
|
def test_overlap_takes_ownership_no_repeat_warning(caplog):
|
|
"""A turn that crashed before its persist warns at most once — the next
|
|
turn takes ownership of the in-flight slot."""
|
|
agent = _FakeAgent()
|
|
with caplog.at_level(logging.WARNING, logger="agent.agent_runtime_helpers"):
|
|
note_turn_start(agent, "s1:t1:aaaa") # never persists (crash)
|
|
note_turn_start(agent, "s1:t2:bbbb") # warns once, takes ownership
|
|
note_turn_persisted(agent)
|
|
note_turn_start(agent, "s1:t3:cccc") # clean again
|
|
assert len(caplog.records) == 1
|
|
|
|
|
|
def test_same_turn_id_reentry_is_silent(caplog):
|
|
"""Re-entering with the same turn_id (retry paths) is not an overlap."""
|
|
agent = _FakeAgent()
|
|
with caplog.at_level(logging.WARNING, logger="agent.agent_runtime_helpers"):
|
|
note_turn_start(agent, "s1:t1:aaaa")
|
|
note_turn_start(agent, "s1:t1:aaaa")
|
|
assert not caplog.records
|