mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
96 lines
3.2 KiB
Python
96 lines
3.2 KiB
Python
"""Tests for the unified ``video_generate`` tool dispatch surface."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from typing import Any, Dict, List, Optional
|
|
|
|
import pytest
|
|
|
|
from agent import video_gen_registry
|
|
from agent.video_gen_provider import VideoGenProvider
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_registry():
|
|
video_gen_registry._reset_for_tests()
|
|
yield
|
|
video_gen_registry._reset_for_tests()
|
|
|
|
|
|
class _RecordingProvider(VideoGenProvider):
|
|
"""Captures the kwargs the tool layer hands it."""
|
|
|
|
def __init__(self, name: str = "fake"):
|
|
self._name = name
|
|
self.last_kwargs: Dict[str, Any] = {}
|
|
|
|
@property
|
|
def name(self) -> str:
|
|
return self._name
|
|
|
|
def list_models(self) -> List[Dict[str, Any]]:
|
|
return [{"id": "model-a"}]
|
|
|
|
def default_model(self) -> Optional[str]:
|
|
return "model-a"
|
|
|
|
def capabilities(self) -> Dict[str, Any]:
|
|
return {"modalities": ["text", "image"]}
|
|
|
|
def generate(self, prompt, **kwargs):
|
|
self.last_kwargs = {"prompt": prompt, **kwargs}
|
|
modality = "image" if kwargs.get("image_url") else "text"
|
|
return {
|
|
"success": True,
|
|
"video": "https://example.com/v.mp4",
|
|
"model": kwargs.get("model") or "model-a",
|
|
"prompt": prompt,
|
|
"modality": modality,
|
|
"aspect_ratio": kwargs.get("aspect_ratio", ""),
|
|
"duration": kwargs.get("duration") or 0,
|
|
"provider": self._name,
|
|
}
|
|
|
|
|
|
class _RaisingProvider(VideoGenProvider):
|
|
@property
|
|
def name(self) -> str:
|
|
return "raises"
|
|
|
|
def generate(self, prompt, **kwargs):
|
|
raise RuntimeError("boom")
|
|
|
|
|
|
class TestUnifiedDispatch:
|
|
def _run(self, args: Dict[str, Any], *, configured: Optional[str] = None) -> Dict[str, Any]:
|
|
from tools import video_generation_tool
|
|
import hermes_cli.plugins as plugins_module
|
|
|
|
saved = video_generation_tool._read_configured_video_provider
|
|
video_generation_tool._read_configured_video_provider = lambda: configured # type: ignore
|
|
saved_discover = plugins_module._ensure_plugins_discovered
|
|
plugins_module._ensure_plugins_discovered = lambda *_a, **_k: None # type: ignore
|
|
try:
|
|
raw = video_generation_tool._handle_video_generate(args)
|
|
finally:
|
|
video_generation_tool._read_configured_video_provider = saved # type: ignore
|
|
plugins_module._ensure_plugins_discovered = saved_discover # type: ignore
|
|
return json.loads(raw)
|
|
|
|
def test_no_provider_returns_clear_error(self):
|
|
result = self._run({"prompt": "a dog"})
|
|
assert result["success"] is False
|
|
assert result["error_type"] == "no_provider_configured"
|
|
|
|
def test_unknown_provider_returns_clear_error(self):
|
|
result = self._run({"prompt": "a dog"}, configured="ghost")
|
|
assert result["success"] is False
|
|
assert result["error_type"] == "provider_not_registered"
|
|
|
|
|
|
def test_edit_extend_fields_not_in_schema(self):
|
|
from tools.video_generation_tool import VIDEO_GENERATE_SCHEMA
|
|
props = VIDEO_GENERATE_SCHEMA["parameters"]["properties"]
|
|
assert "operation" not in props
|
|
assert "video_url" not in props
|