mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
47 lines
1.3 KiB
Python
47 lines
1.3 KiB
Python
"""Export redaction tests — the security-critical layer.
|
|
|
|
Invariants:
|
|
* One unconditional scrub: secrets AND PII, no modes, no knobs.
|
|
* Fails CLOSED: if the redactor can't run, the raw string is never emitted.
|
|
* Structure (subsystem names, error codes) survives; free-text PII does not.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest import mock
|
|
|
|
import agent.monitoring.redaction as R
|
|
|
|
|
|
def test_secret_key_always_stripped():
|
|
fake_key = "sk-ant-api03-" + "A" * 24 # constructed to dodge literal-scrubbers
|
|
out = R.redact_for_export(f"calling with key {fake_key} and moving on")
|
|
assert out is not None
|
|
assert fake_key not in out
|
|
|
|
|
|
|
|
|
|
def test_bearer_header_stripped():
|
|
out = R.redact_for_export("Authorization: Bearer abc.def-ghi_jkl")
|
|
assert out is not None
|
|
assert "abc.def-ghi_jkl" not in out
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_structure_preserved():
|
|
out = R.redact_for_export("platform.slack entered fatal after auth_failed")
|
|
assert out is not None
|
|
assert "platform.slack" in out
|
|
assert "auth_failed" in out
|
|
|
|
|
|
def test_fails_closed_when_redactor_unavailable():
|
|
with mock.patch("agent.redact.redact_sensitive_text", side_effect=RuntimeError):
|
|
out = R.redact_for_export("secret sauce sk-live-key")
|
|
assert out == "[redaction-unavailable]"
|