mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
98 lines
3.3 KiB
Python
98 lines
3.3 KiB
Python
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock
|
|
|
|
import hermes_cli.memory_setup as memory_setup
|
|
from hermes_cli.memory_setup import _CANCELLED, _curses_select
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_cmd_setup_generic_choice_cancel_writes_nothing(tmp_path, monkeypatch):
|
|
class ChoiceProvider:
|
|
def __init__(self):
|
|
self.save_config = MagicMock()
|
|
|
|
def get_config_schema(self):
|
|
return [{
|
|
"key": "mode",
|
|
"description": "Mode",
|
|
"default": "one",
|
|
"choices": ["one", "two"],
|
|
}]
|
|
|
|
provider = ChoiceProvider()
|
|
selections = iter([0, _CANCELLED])
|
|
save_config = MagicMock()
|
|
install_dependencies = MagicMock()
|
|
|
|
monkeypatch.setattr(memory_setup, "_get_available_providers", lambda: [("fake", "local", provider)])
|
|
monkeypatch.setattr(memory_setup, "_curses_select", lambda *args, **kwargs: next(selections))
|
|
monkeypatch.setattr(memory_setup, "_install_dependencies", install_dependencies)
|
|
monkeypatch.setattr(memory_setup, "get_hermes_home", lambda: tmp_path)
|
|
monkeypatch.setattr("hermes_cli.config.load_config", lambda: {"memory": {}})
|
|
monkeypatch.setattr("hermes_cli.config.save_config", save_config)
|
|
|
|
memory_setup.cmd_setup(SimpleNamespace())
|
|
|
|
install_dependencies.assert_called_once_with("fake")
|
|
save_config.assert_not_called()
|
|
provider.save_config.assert_not_called()
|
|
assert not (tmp_path / ".env").exists()
|
|
|
|
|
|
def test_write_env_vars_strips_line_separators_and_nul(tmp_path):
|
|
"""A pasted secret with embedded CR/LF/NUL must not inject an extra
|
|
KEY=VALUE line into .env (mirrors the openviking plugin's writer)."""
|
|
env_path = tmp_path / ".env"
|
|
|
|
memory_setup._write_env_vars(
|
|
env_path,
|
|
{"PROVIDER_API_KEY": "good\nINJECTED_KEY=attacker\r\u2028\x00tail"},
|
|
)
|
|
|
|
lines = env_path.read_text(encoding="utf-8").splitlines()
|
|
assert lines == ["PROVIDER_API_KEY=goodINJECTED_KEY=attackertail"]
|
|
parsed = dict(line.split("=", 1) for line in lines if "=" in line)
|
|
assert set(parsed) == {"PROVIDER_API_KEY"}
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _provider_pip_dependencies — mode-aware dep expansion (#70636)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
def test_install_dependencies_force_reinstalls_versioned_specs(tmp_path, monkeypatch):
|
|
"""force=True hands every declared spec (version ranges intact) to pip,
|
|
so a downgraded/stripped bridge package is restored on hermes update."""
|
|
import yaml as _yaml
|
|
|
|
plugin_dir = tmp_path / "mem0"
|
|
plugin_dir.mkdir()
|
|
(plugin_dir / "plugin.yaml").write_text(
|
|
_yaml.safe_dump({"pip_dependencies": ["mem0ai>=2.0.10,<3"]}), encoding="utf-8"
|
|
)
|
|
monkeypatch.setattr(
|
|
"plugins.memory.find_provider_dir", lambda name: plugin_dir
|
|
)
|
|
|
|
installed = []
|
|
|
|
def fake_install_specs(specs, timeout=120):
|
|
installed.append(list(specs))
|
|
return SimpleNamespace(ok=True, blocked=False, reason="", stderr="")
|
|
|
|
monkeypatch.setattr("tools.lazy_deps.install_specs", fake_install_specs)
|
|
|
|
memory_setup._install_dependencies("mem0", force=True)
|
|
|
|
assert installed, "force=True must reach the install step"
|
|
assert any("mem0ai>=2.0.10,<3" in specs for specs in installed)
|