mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
109 lines
3.4 KiB
Python
109 lines
3.4 KiB
Python
"""Tests for CLI external-editor support."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from cli import HermesCLI
|
|
|
|
|
|
class _FakeBuffer:
|
|
def __init__(self, text=""):
|
|
self.calls = []
|
|
self.text = text
|
|
self.cursor_position = len(text)
|
|
|
|
def open_in_editor(self, validate_and_handle=False):
|
|
self.calls.append(validate_and_handle)
|
|
|
|
|
|
class _FakeApp:
|
|
def __init__(self):
|
|
self.current_buffer = _FakeBuffer()
|
|
|
|
|
|
def _make_cli(with_app=True):
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
cli_obj._app = _FakeApp() if with_app else None
|
|
cli_obj._command_running = False
|
|
cli_obj._command_status = ""
|
|
cli_obj._command_display = ""
|
|
cli_obj._sudo_state = None
|
|
cli_obj._secret_state = None
|
|
cli_obj._approval_state = None
|
|
cli_obj._clarify_state = None
|
|
cli_obj._skip_paste_collapse = False
|
|
return cli_obj
|
|
|
|
def test_open_external_editor_uses_prompt_toolkit_buffer_editor():
|
|
cli_obj = _make_cli()
|
|
|
|
assert cli_obj._open_external_editor() is True
|
|
assert cli_obj._app.current_buffer.calls == [False]
|
|
|
|
|
|
def test_open_external_editor_rejects_when_no_tui():
|
|
cli_obj = _make_cli(with_app=False)
|
|
|
|
with patch("cli._cprint") as mock_cprint:
|
|
assert cli_obj._open_external_editor() is False
|
|
|
|
assert mock_cprint.called
|
|
assert "interactive cli" in str(mock_cprint.call_args).lower()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_open_external_editor_expands_paste_placeholders_before_open(tmp_path):
|
|
cli_obj = _make_cli()
|
|
paste_file = tmp_path / "paste.txt"
|
|
paste_file.write_text("alpha\nbeta", encoding="utf-8")
|
|
buffer = _FakeBuffer(text=f"[Pasted text #1: 2 lines → {paste_file}]")
|
|
|
|
assert cli_obj._open_external_editor(buffer=buffer) is True
|
|
assert buffer.text == "alpha\nbeta"
|
|
assert buffer.cursor_position == len("alpha\nbeta")
|
|
assert buffer.calls == [False]
|
|
|
|
|
|
def test_open_external_editor_sets_skip_collapse_flag_during_expansion(tmp_path):
|
|
cli_obj = _make_cli()
|
|
paste_file = tmp_path / "paste.txt"
|
|
paste_file.write_text("a\nb\nc\nd\ne\nf", encoding="utf-8")
|
|
buffer = _FakeBuffer(text=f"[Pasted text #1: 6 lines \u2192 {paste_file}]")
|
|
|
|
# After expansion the flag should have been set (to prevent re-collapse)
|
|
assert cli_obj._open_external_editor(buffer=buffer) is True
|
|
# Flag is consumed by _on_text_changed, but since no handler is attached
|
|
# in tests it stays True until the handler resets it.
|
|
assert cli_obj._skip_paste_collapse is True
|
|
|
|
|
|
def test_inline_pastes_stores_full_content(tmp_path):
|
|
"""History should recall the actual pasted text, not the placeholder."""
|
|
cli_obj = _make_cli()
|
|
paste_file = tmp_path / "paste.txt"
|
|
paste_file.write_text("line one\nline two", encoding="utf-8")
|
|
buffer = _FakeBuffer(text=f"[Pasted text #1: 2 lines \u2192 {paste_file}]")
|
|
|
|
cli_obj._inline_pastes(buffer)
|
|
|
|
assert buffer.text == "line one\nline two"
|
|
assert buffer.cursor_position == len("line one\nline two")
|
|
# Skip flag set so the resulting text-change doesn't re-collapse.
|
|
assert cli_obj._skip_paste_collapse is True
|
|
|
|
|
|
|
|
|
|
def test_inline_pastes_missing_file_keeps_placeholder(tmp_path):
|
|
"""A recalled reference whose file is gone stays as the placeholder."""
|
|
cli_obj = _make_cli()
|
|
placeholder = f"[Pasted text #1: 2 lines \u2192 {tmp_path / 'gone.txt'}]"
|
|
buffer = _FakeBuffer(text=placeholder)
|
|
|
|
cli_obj._inline_pastes(buffer)
|
|
|
|
assert buffer.text == placeholder
|
|
assert cli_obj._skip_paste_collapse is False
|