mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
80 lines
2.6 KiB
Python
80 lines
2.6 KiB
Python
"""Test that skill_view registers required env vars in the passthrough registry."""
|
|
|
|
import json
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
import tools.env_passthrough as _ep_mod
|
|
from tools.env_passthrough import clear_env_passthrough, is_env_passthrough
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clean_passthrough():
|
|
clear_env_passthrough()
|
|
_ep_mod._config_passthrough = None
|
|
yield
|
|
clear_env_passthrough()
|
|
_ep_mod._config_passthrough = None
|
|
|
|
|
|
def _create_skill(tmp_path, name, frontmatter_extra=""):
|
|
"""Create a minimal skill directory with SKILL.md."""
|
|
skill_dir = tmp_path / name
|
|
skill_dir.mkdir(parents=True, exist_ok=True)
|
|
(skill_dir / "SKILL.md").write_text(
|
|
f"---\n"
|
|
f"name: {name}\n"
|
|
f"description: Test skill\n"
|
|
f"{frontmatter_extra}"
|
|
f"---\n\n"
|
|
f"# {name}\n\n"
|
|
f"Test content.\n"
|
|
)
|
|
return skill_dir
|
|
|
|
|
|
class TestSkillViewRegistersPassthrough:
|
|
def test_available_env_vars_registered(self, tmp_path, monkeypatch):
|
|
"""When a skill declares required_environment_variables and the var IS set,
|
|
it should be registered in the passthrough."""
|
|
_create_skill(
|
|
tmp_path,
|
|
"test-skill",
|
|
frontmatter_extra=(
|
|
"required_environment_variables:\n"
|
|
" - name: TENOR_API_KEY\n"
|
|
" prompt: Enter your Tenor API key\n"
|
|
),
|
|
)
|
|
monkeypatch.setattr(
|
|
"tools.skills_tool.SKILLS_DIR", tmp_path
|
|
)
|
|
# Set the env var so it's "available"
|
|
monkeypatch.setenv("TENOR_API_KEY", "test-value-123")
|
|
|
|
# Patch the secret capture callback to not prompt
|
|
with patch("tools.skills_tool._secret_capture_callback", None):
|
|
from tools.skills_tool import skill_view
|
|
|
|
result = json.loads(skill_view(name="test-skill"))
|
|
|
|
assert result["success"] is True
|
|
assert is_env_passthrough("TENOR_API_KEY")
|
|
|
|
|
|
def test_no_env_vars_skill_no_registration(self, tmp_path, monkeypatch):
|
|
"""Skills without required_environment_variables shouldn't register anything."""
|
|
_create_skill(tmp_path, "simple-skill")
|
|
monkeypatch.setattr(
|
|
"tools.skills_tool.SKILLS_DIR", tmp_path
|
|
)
|
|
|
|
with patch("tools.skills_tool._secret_capture_callback", None):
|
|
from tools.skills_tool import skill_view
|
|
|
|
result = json.loads(skill_view(name="simple-skill"))
|
|
|
|
assert result["success"] is True
|
|
from tools.env_passthrough import get_all_passthrough
|
|
assert len(get_all_passthrough()) == 0
|