mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
87 lines
3.2 KiB
Python
87 lines
3.2 KiB
Python
"""Tests for tools.hook_output_spill."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
from tools import hook_output_spill as hos
|
|
|
|
|
|
class GetSpillConfigTests(unittest.TestCase):
|
|
def test_defaults_when_no_config(self):
|
|
with patch.object(hos, "load_config", create=True, return_value={}):
|
|
# load_config is resolved at call time via local import;
|
|
# patch the module's source instead.
|
|
pass
|
|
with patch("hermes_cli.config.load_config", return_value={}):
|
|
cfg = hos.get_spill_config()
|
|
self.assertTrue(cfg["enabled"])
|
|
self.assertEqual(cfg["max_chars"], hos.DEFAULT_MAX_CHARS)
|
|
self.assertEqual(cfg["preview_head"], hos.DEFAULT_PREVIEW_HEAD)
|
|
self.assertEqual(cfg["preview_tail"], hos.DEFAULT_PREVIEW_TAIL)
|
|
self.assertIsNone(cfg["directory"])
|
|
|
|
|
|
def test_load_config_exception_is_swallowed(self):
|
|
with patch("hermes_cli.config.load_config", side_effect=RuntimeError("bad")):
|
|
cfg = hos.get_spill_config()
|
|
self.assertEqual(cfg["max_chars"], hos.DEFAULT_MAX_CHARS)
|
|
self.assertTrue(cfg["enabled"])
|
|
|
|
|
|
class SpillIfOversizedTests(unittest.TestCase):
|
|
def setUp(self):
|
|
self.tmpdir = tempfile.mkdtemp(prefix="hermes-spill-test-")
|
|
|
|
def tearDown(self):
|
|
import shutil
|
|
shutil.rmtree(self.tmpdir, ignore_errors=True)
|
|
|
|
def _cfg(self, **overrides):
|
|
base = {
|
|
"enabled": True,
|
|
"max_chars": 100,
|
|
"preview_head": 20,
|
|
"preview_tail": 20,
|
|
"directory": self.tmpdir,
|
|
}
|
|
base.update(overrides)
|
|
return base
|
|
|
|
def test_empty_and_none_are_noops(self):
|
|
self.assertEqual(hos.spill_if_oversized("", config=self._cfg()), "")
|
|
self.assertEqual(hos.spill_if_oversized(None, config=self._cfg()), "")
|
|
|
|
def test_text_under_cap_is_unchanged(self):
|
|
small = "x" * 50
|
|
self.assertEqual(hos.spill_if_oversized(small, config=self._cfg()), small)
|
|
|
|
|
|
def test_default_directory_uses_hermes_home(self):
|
|
"""When no directory override, spill under HERMES_HOME/hook_outputs."""
|
|
test_home = tempfile.mkdtemp(prefix="hermes-home-")
|
|
try:
|
|
with patch.dict(os.environ, {"HERMES_HOME": test_home}):
|
|
# Also patch get_hermes_home to the env var to mirror production.
|
|
cfg = self._cfg(directory=None, max_chars=5)
|
|
hos.spill_if_oversized("x" * 200, session_id="sess", config=cfg)
|
|
# Spill directory exists somewhere under test_home OR default
|
|
# ~/.hermes/hook_outputs depending on get_hermes_home behaviour.
|
|
candidates = [
|
|
Path(test_home) / "hook_outputs" / "sess",
|
|
Path(os.path.expanduser("~/.hermes/hook_outputs/sess")),
|
|
]
|
|
# At least one of the candidate dirs now exists and has a file.
|
|
existing = [c for c in candidates if c.is_dir() and list(c.iterdir())]
|
|
self.assertTrue(existing, f"No spill dir found in {candidates}")
|
|
finally:
|
|
import shutil
|
|
shutil.rmtree(test_home, ignore_errors=True)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|