mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
125 lines
4.4 KiB
Python
125 lines
4.4 KiB
Python
"""Tests for Honcho client configuration."""
|
|
|
|
import json
|
|
import os
|
|
import stat
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from plugins.memory.honcho.client import HonchoClientConfig
|
|
from plugins.memory.honcho import HonchoMemoryProvider
|
|
|
|
|
|
class TestHonchoClientConfigAutoEnable:
|
|
"""Test auto-enable behavior when API key is present."""
|
|
|
|
def test_auto_enables_when_api_key_present_no_explicit_enabled(self, tmp_path):
|
|
"""When API key exists and enabled is not set, should auto-enable."""
|
|
config_path = tmp_path / "config.json"
|
|
config_path.write_text(json.dumps({
|
|
"apiKey": "test-api-key-12345",
|
|
# Note: no "enabled" field
|
|
}))
|
|
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
|
|
assert cfg.api_key == "test-api-key-12345"
|
|
assert cfg.enabled is True # Auto-enabled because API key exists
|
|
|
|
def test_respects_explicit_enabled_false(self, tmp_path):
|
|
"""When enabled is explicitly False, should stay disabled even with API key."""
|
|
config_path = tmp_path / "config.json"
|
|
config_path.write_text(json.dumps({
|
|
"apiKey": "test-api-key-12345",
|
|
"enabled": False, # Explicitly disabled
|
|
}))
|
|
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
|
|
assert cfg.api_key == "test-api-key-12345"
|
|
assert cfg.enabled is False # Respects explicit setting
|
|
|
|
|
|
def test_disabled_when_no_api_key_and_no_explicit_enabled(self, tmp_path):
|
|
"""When no API key and enabled not set, should be disabled."""
|
|
config_path = tmp_path / "config.json"
|
|
config_path.write_text(json.dumps({
|
|
"workspace": "test",
|
|
# No apiKey, no enabled
|
|
}))
|
|
|
|
# Clear env var if set
|
|
env_key = os.environ.pop("HONCHO_API_KEY", None)
|
|
try:
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
assert cfg.api_key is None
|
|
assert cfg.enabled is False # No API key = not enabled
|
|
finally:
|
|
if env_key:
|
|
os.environ["HONCHO_API_KEY"] = env_key
|
|
|
|
|
|
def test_from_env_always_enabled(self, monkeypatch):
|
|
"""from_env() should always set enabled=True."""
|
|
monkeypatch.setenv("HONCHO_API_KEY", "env-test-key")
|
|
|
|
cfg = HonchoClientConfig.from_env()
|
|
|
|
assert cfg.api_key == "env-test-key"
|
|
assert cfg.enabled is True
|
|
|
|
|
|
|
|
@pytest.mark.skipif(os.name == "nt", reason="POSIX mode bits not enforced on Windows")
|
|
def test_save_config_sets_owner_only_permissions(tmp_path, monkeypatch):
|
|
"""honcho.json is created atomically with 0o600, not chmod-after-write."""
|
|
import utils
|
|
calls = []
|
|
real_atomic = utils.atomic_json_write
|
|
|
|
def spy(path, data, **kwargs):
|
|
calls.append(kwargs.get("mode"))
|
|
return real_atomic(path, data, **kwargs)
|
|
|
|
monkeypatch.setattr(utils, "atomic_json_write", spy)
|
|
provider = HonchoMemoryProvider()
|
|
provider.save_config({"api_key": "hc-test-key"}, str(tmp_path))
|
|
assert calls == [0o600]
|
|
config_file = tmp_path / "honcho.json"
|
|
assert config_file.exists()
|
|
mode = stat.S_IMODE(config_file.stat().st_mode)
|
|
assert mode == 0o600, f"Expected 0o600 (owner-only), got {oct(mode)}"
|
|
|
|
|
|
class TestLatencyFlagResolution:
|
|
|
|
def test_host_block_wins(self, tmp_path, monkeypatch):
|
|
monkeypatch.delenv('HONCHO_BASE_URL', raising=False)
|
|
config_path = tmp_path / 'config.json'
|
|
config_path.write_text(json.dumps({
|
|
'apiKey': 'k',
|
|
'queryRewrite': False,
|
|
'firstTurnBaseWait': 3,
|
|
'hosts': {'hermes': {
|
|
'queryRewrite': True,
|
|
'firstTurnBaseWait': 0,
|
|
'firstTurnDialecticWait': 0.5,
|
|
}},
|
|
}))
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
assert cfg.query_rewrite is True
|
|
assert cfg.first_turn_base_wait == 0.0
|
|
assert cfg.first_turn_dialectic_wait == 0.5
|
|
|
|
def test_per_host_timeout_wins_over_global(self, tmp_path, monkeypatch):
|
|
monkeypatch.delenv('HONCHO_TIMEOUT', raising=False)
|
|
config_path = tmp_path / 'config.json'
|
|
config_path.write_text(json.dumps({
|
|
'apiKey': 'k',
|
|
'timeout': 30,
|
|
'hosts': {'hermes': {'timeout': 5}},
|
|
}))
|
|
cfg = HonchoClientConfig.from_global_config(config_path=config_path)
|
|
assert cfg.timeout == 5.0
|
|
|