mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
56 lines
1.9 KiB
Python
56 lines
1.9 KiB
Python
"""Tests for skills/media/youtube-content/scripts/fetch_transcript.py (issue #22243)."""
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest import mock
|
|
|
|
import pytest
|
|
|
|
SCRIPTS_DIR = Path(__file__).resolve().parents[2] / "skills" / "media" / "youtube-content" / "scripts"
|
|
sys.path.insert(0, str(SCRIPTS_DIR))
|
|
|
|
import fetch_transcript
|
|
|
|
|
|
class TestExtractVideoId:
|
|
def test_standard_watch_url(self):
|
|
assert fetch_transcript.extract_video_id("https://www.youtube.com/watch?v=dQw4w9WgXcQ") == "dQw4w9WgXcQ"
|
|
|
|
def test_short_url(self):
|
|
assert fetch_transcript.extract_video_id("https://youtu.be/dQw4w9WgXcQ") == "dQw4w9WgXcQ"
|
|
|
|
|
|
def test_shorts_url(self):
|
|
assert fetch_transcript.extract_video_id("https://www.youtube.com/shorts/dQw4w9WgXcQ") == "dQw4w9WgXcQ"
|
|
|
|
|
|
def test_with_extra_params(self):
|
|
assert fetch_transcript.extract_video_id("https://www.youtube.com/watch?v=dQw4w9WgXcQ&t=42") == "dQw4w9WgXcQ"
|
|
|
|
|
|
class TestFormatTimestamp:
|
|
def test_seconds_only(self):
|
|
assert fetch_transcript.format_timestamp(90) == "1:30"
|
|
|
|
|
|
def test_zero(self):
|
|
assert fetch_transcript.format_timestamp(0) == "0:00"
|
|
|
|
def test_minutes_only(self):
|
|
assert fetch_transcript.format_timestamp(600) == "10:00"
|
|
|
|
|
|
|
|
|
|
class TestPyprojectDeclaresYoutubeExtra:
|
|
def test_youtube_extra_declared_in_pyproject(self):
|
|
"""youtube-transcript-api must be listed in pyproject.toml [youtube] extra (issue #22243)."""
|
|
import tomllib
|
|
pyproject_path = Path(__file__).resolve().parents[2] / "pyproject.toml"
|
|
with pyproject_path.open("rb") as f:
|
|
data = tomllib.load(f)
|
|
extras = data.get("project", {}).get("optional-dependencies", {})
|
|
assert "youtube" in extras, "Missing [youtube] extra in pyproject.toml"
|
|
youtube_deps = " ".join(extras["youtube"])
|
|
assert "youtube-transcript-api" in youtube_deps
|
|
|