mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
47 lines
1.7 KiB
Python
47 lines
1.7 KiB
Python
"""Tests for the /model picker background cache prewarm.
|
|
|
|
``prewarm_picker_cache_async()`` warms the provider-models disk cache off the
|
|
user's critical path so the first ``/model`` open in a session is fast instead
|
|
of blocking ~1-2s on serial /v1/models fetches. These pin the two contracts
|
|
that matter: it runs the warm path exactly once per process (no thread leak),
|
|
and it delegates to ``list_authenticated_providers`` to do the warming.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import patch
|
|
|
|
import hermes_cli.model_switch as ms
|
|
|
|
|
|
def _reset_guard():
|
|
ms._picker_prewarm_done.clear()
|
|
|
|
|
|
def test_prewarm_runs_list_authenticated_providers_once():
|
|
"""First call spawns a thread that calls list_authenticated_providers;
|
|
the warm side effect is delegated there (which disk-caches per provider)."""
|
|
_reset_guard()
|
|
with patch.object(ms, "list_authenticated_providers", return_value=[]) as mock_list:
|
|
t = ms.prewarm_picker_cache_async()
|
|
assert t is not None, "first call must spawn a prewarm thread"
|
|
t.join(timeout=10)
|
|
assert not t.is_alive(), "prewarm thread should finish promptly"
|
|
mock_list.assert_called_once()
|
|
_reset_guard()
|
|
|
|
|
|
def test_prewarm_guard_is_once_per_process():
|
|
"""The process-level Event guard must make repeat calls no-ops so a
|
|
long-lived process never leaks one OS thread per call."""
|
|
_reset_guard()
|
|
with patch.object(ms, "list_authenticated_providers", return_value=[]):
|
|
t1 = ms.prewarm_picker_cache_async()
|
|
assert t1 is not None
|
|
t1.join(timeout=10)
|
|
# Subsequent calls return None (guard set) — no new thread.
|
|
assert ms.prewarm_picker_cache_async() is None
|
|
assert ms.prewarm_picker_cache_async() is None
|
|
_reset_guard()
|
|
|
|
|