mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
62 lines
2.3 KiB
Python
62 lines
2.3 KiB
Python
"""Test that overlay providers with mismatched models.dev keys resolve correctly.
|
|
|
|
HERMES_OVERLAYS keys may be models.dev IDs (e.g. "github-copilot") while
|
|
_PROVIDER_MODELS and config.yaml use Hermes IDs ("copilot"). The slug
|
|
resolution in list_authenticated_providers() Section 2 must bridge this gap.
|
|
|
|
Covers: #5223, #6492
|
|
"""
|
|
|
|
import os
|
|
from unittest.mock import patch
|
|
|
|
|
|
from hermes_cli.model_switch import list_authenticated_providers
|
|
|
|
|
|
# -- Copilot slug resolution (env var path) ----------------------------------
|
|
|
|
@patch.dict(os.environ, {"COPILOT_GITHUB_TOKEN": "fake-ghu"}, clear=False)
|
|
def test_copilot_uses_hermes_slug():
|
|
"""github-copilot overlay should resolve to slug='copilot' with curated models."""
|
|
providers = list_authenticated_providers(current_provider="copilot")
|
|
|
|
copilot = next((p for p in providers if p["slug"] == "copilot"), None)
|
|
assert copilot is not None, "copilot should appear when COPILOT_GITHUB_TOKEN is set"
|
|
assert copilot["total_models"] > 0, "copilot should have curated models"
|
|
assert copilot["is_current"] is True
|
|
|
|
# Must NOT appear under the models.dev key
|
|
gh_copilot = next((p for p in providers if p["slug"] == "github-copilot"), None)
|
|
assert gh_copilot is None, "github-copilot slug should not appear (resolved to copilot)"
|
|
|
|
|
|
|
|
|
|
# -- kimi-for-coding alias in auth.py ----------------------------------------
|
|
|
|
|
|
|
|
# -- Generic slug mismatch providers -----------------------------------------
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_mapped_provider_credential_pool_visibility(monkeypatch):
|
|
"""Mapped providers should appear when credentials live only in auth-store credential_pool."""
|
|
monkeypatch.setattr("agent.models_dev.fetch_models_dev", lambda: {"google-ai-studio": {"env": ["GEMINI_API_KEY"]}})
|
|
monkeypatch.setattr("agent.models_dev.PROVIDER_TO_MODELS_DEV", {"gemini": "google-ai-studio"})
|
|
monkeypatch.setattr(
|
|
"hermes_cli.auth._load_auth_store",
|
|
lambda: {"providers": {}, "credential_pool": {"gemini": {"token": "fake"}}},
|
|
)
|
|
monkeypatch.delenv("GEMINI_API_KEY", raising=False)
|
|
|
|
providers = list_authenticated_providers(current_provider="gemini")
|
|
|
|
gemini = next((p for p in providers if p["slug"] == "gemini"), None)
|
|
assert gemini is not None, "gemini should appear when auth-store credential_pool has creds"
|
|
assert gemini["is_current"] is True
|
|
assert gemini["total_models"] > 0
|