mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
95 lines
3.4 KiB
Python
95 lines
3.4 KiB
Python
"""Regression tests for #27145 — kanban.default_assignee for unassigned ready tasks.
|
|
|
|
When the dispatcher hits an unassigned ready task and ``kanban.default_assignee``
|
|
is set, the dispatcher applies the assignment and spawns. Without the config,
|
|
the task is skipped (existing behavior preserved).
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import sys
|
|
import tempfile
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture()
|
|
def isolated_kanban_home(monkeypatch):
|
|
"""Spin up a fresh HERMES_HOME with a clean kanban DB."""
|
|
test_home = tempfile.mkdtemp(prefix="kanban_default_assignee_test_")
|
|
monkeypatch.setenv("HERMES_HOME", test_home)
|
|
# Force-reimport so the fresh HERMES_HOME is picked up.
|
|
for mod in list(sys.modules.keys()):
|
|
if mod.startswith("hermes_cli") or mod.startswith("hermes_state") or mod == "hermes_constants":
|
|
del sys.modules[mod]
|
|
from hermes_cli import kanban_db
|
|
yield kanban_db, test_home
|
|
# Cleanup is best-effort; tempfile dir survives but pytest isolation
|
|
# gives each test its own monkeypatched HERMES_HOME so no cross-test
|
|
# contamination.
|
|
|
|
|
|
def _fake_spawn(*args, **kwargs):
|
|
"""Stand-in for the real worker spawn — returns a fake PID."""
|
|
return 12345
|
|
|
|
|
|
|
|
|
|
def test_unassigned_task_auto_assigned_with_default_assignee(isolated_kanban_home):
|
|
"""Core #27145 contract: with default_assignee set, an unassigned ready
|
|
task gets the assignment applied and dispatched on the same tick. The
|
|
DB row is mutated (assignee column + an 'assigned' event)."""
|
|
kb, _home = isolated_kanban_home
|
|
with kb.connect_closing() as conn:
|
|
kb.create_board(slug="default", name="Test")
|
|
task_id = kb.create_task(conn, title="t1", assignee=None)
|
|
with kb.connect_closing() as conn:
|
|
res = kb.dispatch_once(
|
|
conn, spawn_fn=_fake_spawn, dry_run=False,
|
|
default_assignee="default",
|
|
)
|
|
assert res.auto_assigned_default == [task_id]
|
|
assert not res.skipped_unassigned
|
|
assert len(res.spawned) == 1
|
|
assert res.spawned[0][0] == task_id
|
|
assert res.spawned[0][1] == "default"
|
|
|
|
with kb.connect_closing() as conn:
|
|
row = conn.execute("SELECT assignee FROM tasks WHERE id = ?", (task_id,)).fetchone()
|
|
assert row["assignee"] == "default"
|
|
|
|
# 'assigned' event emitted for the audit trail
|
|
with kb.connect_closing() as conn:
|
|
evs = list(conn.execute(
|
|
"SELECT kind, payload FROM task_events WHERE task_id = ? AND kind = 'assigned'",
|
|
(task_id,),
|
|
))
|
|
assert len(evs) == 1
|
|
payload = json.loads(evs[0][1])
|
|
assert payload["assignee"] == "default"
|
|
assert payload["source"] == "kanban.default_assignee"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_explicitly_assigned_task_untouched_by_default_assignee(isolated_kanban_home):
|
|
"""A task with an explicit assignee must NOT be touched by the
|
|
default_assignee logic — that fallback only applies to genuinely
|
|
unassigned rows."""
|
|
kb, _home = isolated_kanban_home
|
|
with kb.connect_closing() as conn:
|
|
kb.create_board(slug="default", name="Test")
|
|
task_id = kb.create_task(conn, title="t1", assignee="default")
|
|
with kb.connect_closing() as conn:
|
|
res = kb.dispatch_once(
|
|
conn, spawn_fn=_fake_spawn, dry_run=False,
|
|
default_assignee="someother",
|
|
)
|
|
assert task_id not in res.auto_assigned_default
|
|
assert any(s[0] == task_id and s[1] == "default" for s in res.spawned)
|
|
|
|
|