mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
76 lines
2.5 KiB
Python
76 lines
2.5 KiB
Python
"""Telegram voice-message captions must render markdown (#32029).
|
|
|
|
``TelegramAdapter.send_voice`` used to pass captions raw with no
|
|
``parse_mode``, so auto-TTS captions carrying the agent's markdown reply
|
|
showed literal *asterisks*, backticks and [links](...). It now formats the
|
|
caption to MarkdownV2 (when the formatted text fits the 1024-char caption
|
|
cap) and falls back to the plain truncated caption when the Bot API rejects
|
|
the entities or formatting overflows.
|
|
"""
|
|
import sys
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import PlatformConfig
|
|
|
|
|
|
def _ensure_telegram_mock():
|
|
if "telegram" in sys.modules and hasattr(sys.modules["telegram"], "__file__"):
|
|
return
|
|
mod = MagicMock()
|
|
mod.error.NetworkError = type("NetworkError", (OSError,), {})
|
|
mod.error.TimedOut = type("TimedOut", (OSError,), {})
|
|
mod.error.BadRequest = type("BadRequest", (Exception,), {})
|
|
for name in ("telegram", "telegram.ext", "telegram.constants", "telegram.request"):
|
|
sys.modules.setdefault(name, mod)
|
|
sys.modules.setdefault("telegram.error", mod.error)
|
|
|
|
|
|
_ensure_telegram_mock()
|
|
|
|
from plugins.platforms.telegram import adapter as telegram_mod # noqa: E402
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter # noqa: E402
|
|
|
|
|
|
def _make_adapter() -> TelegramAdapter:
|
|
adapter = TelegramAdapter(PlatformConfig(enabled=True, token="***"))
|
|
adapter._bot = MagicMock()
|
|
adapter._bot.send_voice = AsyncMock(return_value=MagicMock(message_id=1))
|
|
adapter._bot.send_audio = AsyncMock(return_value=MagicMock(message_id=2))
|
|
return adapter
|
|
|
|
|
|
def _write_ogg(tmp_path):
|
|
audio = tmp_path / "reply.ogg"
|
|
audio.write_bytes(b"\x00" * 16)
|
|
return audio
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_voice_caption_falls_back_to_plain_on_entity_rejection(
|
|
monkeypatch, tmp_path
|
|
):
|
|
"""A Bot API entity-parse rejection retries with the plain caption."""
|
|
monkeypatch.setattr(
|
|
telegram_mod, "_probe_voice_duration_seconds", lambda _p: 3
|
|
)
|
|
adapter = _make_adapter()
|
|
adapter._bot.send_voice = AsyncMock(
|
|
side_effect=[
|
|
Exception("Bad Request: can't parse entities"),
|
|
MagicMock(message_id=7),
|
|
]
|
|
)
|
|
|
|
result = await adapter.send_voice(
|
|
"123", str(_write_ogg(tmp_path)), caption="*bold* reply"
|
|
)
|
|
|
|
assert result.success is True
|
|
assert adapter._bot.send_voice.await_count == 2
|
|
retry_kwargs = adapter._bot.send_voice.await_args_list[1].kwargs
|
|
assert retry_kwargs["parse_mode"] is None
|
|
assert retry_kwargs["caption"] == "*bold* reply"
|
|
|
|
|