mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
61 lines
2.1 KiB
Python
61 lines
2.1 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import sqlite3
|
|
from pathlib import Path
|
|
|
|
from gateway.readiness import collect_runtime_readiness
|
|
|
|
|
|
def test_collect_runtime_readiness_reports_healthy_local_runtime(tmp_path, monkeypatch):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
(home / "config.yaml").write_text(
|
|
"model:\n provider: openrouter\n model: test/model\n",
|
|
encoding="utf-8",
|
|
)
|
|
with sqlite3.connect(home / "state.db") as conn:
|
|
conn.execute("CREATE TABLE probe (id INTEGER PRIMARY KEY)")
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
|
|
result = collect_runtime_readiness(
|
|
configured_model="test/model",
|
|
runtime_status={
|
|
"gateway_state": "running",
|
|
"platforms": {"telegram": {"state": "connected"}},
|
|
"updated_at": "2026-07-09T00:00:00Z",
|
|
},
|
|
active_api_runs=2,
|
|
)
|
|
|
|
assert result["status"] == "ok"
|
|
assert result["checks"]["state_db"]["status"] == "ok"
|
|
assert result["checks"]["config"]["status"] == "ok"
|
|
assert result["checks"]["model"]["status"] == "ok"
|
|
assert result["checks"]["gateway"]["status"] == "ok"
|
|
assert result["checks"]["background_queues"]["active_api_runs"] == 2
|
|
assert result["checks"]["disk"]["status"] in {"ok", "degraded"}
|
|
|
|
|
|
def test_collect_runtime_readiness_degrades_on_invalid_config_and_stopped_gateway(
|
|
tmp_path, monkeypatch
|
|
):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
(home / "config.yaml").write_text("model: [unterminated", encoding="utf-8")
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
|
|
result = collect_runtime_readiness(
|
|
configured_model="",
|
|
runtime_status={"gateway_state": "stopped", "platforms": {}},
|
|
)
|
|
|
|
assert result["status"] == "degraded"
|
|
assert result["checks"]["config"]["status"] == "degraded"
|
|
assert result["checks"]["model"]["status"] == "degraded"
|
|
assert result["checks"]["gateway"]["status"] == "degraded"
|
|
# Readiness is diagnostic data, not an exception or a destructive repair.
|
|
assert (home / "config.yaml").read_text(encoding="utf-8") == "model: [unterminated"
|
|
|
|
|