mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
304 lines
12 KiB
Python
304 lines
12 KiB
Python
"""Tests for gateway.display_config — per-platform display/verbosity resolver."""
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Resolver: resolution order
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestResolveDisplaySetting:
|
|
"""resolve_display_setting() resolves with correct priority."""
|
|
|
|
def test_explicit_platform_override_wins(self):
|
|
"""display.platforms.<plat>.<key> takes top priority."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
config = {
|
|
"display": {
|
|
"tool_progress": "all",
|
|
"platforms": {
|
|
"telegram": {"tool_progress": "verbose"},
|
|
},
|
|
}
|
|
}
|
|
assert resolve_display_setting(config, "telegram", "tool_progress") == "verbose"
|
|
|
|
def test_global_setting_when_no_platform_override(self):
|
|
"""Falls back to display.<key> when no platform override exists."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
config = {
|
|
"display": {
|
|
"tool_progress": "new",
|
|
"platforms": {},
|
|
}
|
|
}
|
|
assert resolve_display_setting(config, "telegram", "tool_progress") == "new"
|
|
|
|
|
|
def test_platform_override_only_affects_that_platform(self):
|
|
"""Other platforms are unaffected by a specific platform override."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
config = {
|
|
"display": {
|
|
"tool_progress": "all",
|
|
"platforms": {
|
|
"slack": {"tool_progress": "off"},
|
|
},
|
|
}
|
|
}
|
|
assert resolve_display_setting(config, "slack", "tool_progress") == "off"
|
|
assert resolve_display_setting(config, "telegram", "tool_progress") == "all"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Backward compatibility: tool_progress_overrides
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestBackwardCompat:
|
|
"""Legacy tool_progress_overrides is still respected as a fallback."""
|
|
|
|
def test_legacy_overrides_read(self):
|
|
"""tool_progress_overrides is read when no platforms entry exists."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
config = {
|
|
"display": {
|
|
"tool_progress": "all",
|
|
"tool_progress_overrides": {
|
|
"signal": "off",
|
|
"telegram": "verbose",
|
|
},
|
|
}
|
|
}
|
|
assert resolve_display_setting(config, "signal", "tool_progress") == "off"
|
|
assert resolve_display_setting(config, "telegram", "tool_progress") == "verbose"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# YAML normalisation
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestYAMLNormalisation:
|
|
"""YAML 1.1 quirks (bare off → False, on → True) are handled."""
|
|
|
|
def test_tool_progress_false_normalised_to_off(self):
|
|
"""YAML's bare `off` parses as False — normalised to 'off' string."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
config = {"display": {"tool_progress": False}}
|
|
assert resolve_display_setting(config, "telegram", "tool_progress") == "off"
|
|
|
|
|
|
def test_only_long_running_visibility_accepts_generic_mode(self):
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
config = {
|
|
"display": {
|
|
"platforms": {
|
|
"whatsapp": {
|
|
"thinking_progress": "generic",
|
|
"interim_assistant_messages": "generic",
|
|
"long_running_notifications": "generic",
|
|
}
|
|
}
|
|
}
|
|
}
|
|
assert resolve_display_setting(config, "whatsapp", "thinking_progress") is False
|
|
assert resolve_display_setting(config, "whatsapp", "interim_assistant_messages") is False
|
|
assert resolve_display_setting(config, "whatsapp", "long_running_notifications") == "generic"
|
|
|
|
def test_thinking_progress_string_false_normalised_to_false(self):
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
config = {"display": {"platforms": {"whatsapp": {"thinking_progress": "false"}}}}
|
|
assert resolve_display_setting(config, "whatsapp", "thinking_progress") is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Built-in platform defaults (tier system)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestPlatformDefaults:
|
|
"""Built-in defaults reflect platform capability tiers."""
|
|
|
|
def test_high_tier_platforms(self):
|
|
"""Discord defaults to 'all'; Telegram defaults quiet for mobile."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
# Telegram: tier_high transport, but quiet mobile default.
|
|
assert resolve_display_setting({}, "telegram", "tool_progress") == "off"
|
|
# Discord: pure tier_high.
|
|
assert resolve_display_setting({}, "discord", "tool_progress") == "all"
|
|
|
|
|
|
def test_low_tier_platforms(self):
|
|
"""Signal, BlueBubbles, etc. default to 'off' tool progress."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
for plat in ("signal", "bluebubbles", "weixin", "wecom", "dingtalk", "whatsapp_cloud"):
|
|
assert resolve_display_setting({}, plat, "tool_progress") == "off", plat
|
|
|
|
|
|
def test_telegram_mobile_chatter_defaults(self):
|
|
"""Telegram keeps real mid-turn signal (interim commentary + heartbeats)
|
|
but skips the verbose busy-ack iteration counter by default."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
# Real model voice — keep on. Without this, Telegram users see
|
|
# "typing..." for the entire turn duration with no feedback.
|
|
assert resolve_display_setting({}, "telegram", "interim_assistant_messages") is True
|
|
# Periodic "Working — N min" heartbeat — keep on. Otherwise long
|
|
# turns appear completely silent.
|
|
assert resolve_display_setting({}, "telegram", "long_running_notifications") is True
|
|
# Verbose iteration counter in busy-ack and heartbeat — off by
|
|
# default on Telegram (mobile chat is cramped enough without
|
|
# "iteration 21/60" debug detail).
|
|
assert resolve_display_setting({}, "telegram", "busy_ack_detail") is False
|
|
# Discord keeps all of these on (desktop-first, more vertical space).
|
|
assert resolve_display_setting({}, "discord", "interim_assistant_messages") is True
|
|
assert resolve_display_setting({}, "discord", "long_running_notifications") is True
|
|
assert resolve_display_setting({}, "discord", "busy_ack_detail") is True
|
|
|
|
def test_slack_workspace_chatter_defaults(self):
|
|
"""Slack should not leave permanent heartbeat/debug breadcrumbs in channels."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
assert resolve_display_setting({}, "slack", "tool_progress") == "off"
|
|
assert resolve_display_setting({}, "slack", "long_running_notifications") is False
|
|
assert resolve_display_setting({}, "slack", "busy_ack_detail") is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Config migration: tool_progress_overrides → display.platforms
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestConfigMigration:
|
|
"""Version 16 migration moves tool_progress_overrides into display.platforms."""
|
|
|
|
def test_migration_creates_platforms_entries(self, tmp_path, monkeypatch):
|
|
"""Old overrides are migrated into display.platforms.<plat>.tool_progress."""
|
|
import yaml
|
|
|
|
config_path = tmp_path / "config.yaml"
|
|
config = {
|
|
"_config_version": 15,
|
|
"display": {
|
|
"tool_progress_overrides": {
|
|
"signal": "off",
|
|
"telegram": "all",
|
|
},
|
|
},
|
|
}
|
|
config_path.write_text(yaml.dump(config), encoding="utf-8")
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
# Re-import to pick up the new HERMES_HOME
|
|
import importlib
|
|
import hermes_cli.config as cfg_mod
|
|
importlib.reload(cfg_mod)
|
|
|
|
result = cfg_mod.migrate_config(interactive=False, quiet=True)
|
|
# Re-read config
|
|
updated = yaml.safe_load(config_path.read_text(encoding="utf-8"))
|
|
platforms = updated.get("display", {}).get("platforms", {})
|
|
assert platforms.get("signal", {}).get("tool_progress") == "off"
|
|
assert platforms.get("telegram", {}).get("tool_progress") == "all"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Streaming per-platform (None = follow global)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestStreamingPerPlatform:
|
|
"""Streaming per-platform override semantics."""
|
|
|
|
|
|
def test_explicit_false_disables(self):
|
|
"""Explicit False disables streaming for that platform."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
config = {
|
|
"display": {
|
|
"platforms": {"telegram": {"streaming": False}},
|
|
}
|
|
}
|
|
assert resolve_display_setting(config, "telegram", "streaming") is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# cleanup_progress — opt-in deletion of temporary progress bubbles
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestCleanupProgress:
|
|
"""``cleanup_progress`` is off by default and resolvable per-platform."""
|
|
|
|
def test_default_off_for_all_platforms(self):
|
|
"""No config set → cleanup_progress resolves to False everywhere."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
for plat in ("telegram", "discord", "slack", "email"):
|
|
assert resolve_display_setting({}, plat, "cleanup_progress") is False
|
|
|
|
|
|
def test_yaml_true_string_normalises_to_true(self):
|
|
"""String 'true'/'yes'/'on' all resolve to True."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
for val in ("true", "yes", "on", "1"):
|
|
config = {
|
|
"display": {
|
|
"platforms": {"telegram": {"cleanup_progress": val}},
|
|
}
|
|
}
|
|
assert resolve_display_setting(config, "telegram", "cleanup_progress") is True, val
|
|
|
|
|
|
class TestToolProgressGrouping:
|
|
"""resolve_display_setting() for the tool_progress_grouping knob."""
|
|
|
|
def test_default_is_accumulate(self):
|
|
"""No config anywhere → global default 'accumulate'."""
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
assert (
|
|
resolve_display_setting({}, "telegram", "tool_progress_grouping")
|
|
== "accumulate"
|
|
)
|
|
|
|
def test_global_separate(self):
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
config = {"display": {"tool_progress_grouping": "separate"}}
|
|
assert (
|
|
resolve_display_setting(config, "discord", "tool_progress_grouping")
|
|
== "separate"
|
|
)
|
|
|
|
|
|
class TestReasoningStyle:
|
|
"""Per-platform reasoning render style (code | blockquote | subtext)."""
|
|
|
|
def test_discord_defaults_to_subtext(self):
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
assert resolve_display_setting({}, "discord", "reasoning_style") == "subtext"
|
|
|
|
def test_other_platforms_default_to_code(self):
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
for plat in ("telegram", "slack", "matrix", "api_server"):
|
|
assert (
|
|
resolve_display_setting({}, plat, "reasoning_style") == "code"
|
|
), plat
|
|
|
|
|
|
class TestLiveStatusSetting:
|
|
"""display.live_status — tri-state normalisation + platform overrides."""
|
|
|
|
def test_default_is_full(self):
|
|
from gateway.display_config import resolve_display_setting
|
|
|
|
assert resolve_display_setting({}, "slack", "live_status") == "full"
|
|
|
|
|