mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
77 lines
2.7 KiB
Python
77 lines
2.7 KiB
Python
"""Status-bar goal segment (⊙ goal N/M) — active-goal-only rendering.
|
|
|
|
The segment mirrors the desktop composer goal indicator: it appears only
|
|
while a /goal is ACTIVE, shows turns used vs the turn budget, and stays out
|
|
of the bar entirely for paused/done/absent goals (those already print their
|
|
own glyph lines in the conversation thread).
|
|
"""
|
|
|
|
from datetime import datetime, timedelta
|
|
from types import SimpleNamespace
|
|
|
|
from cli import HermesCLI
|
|
|
|
|
|
def _make_cli(model: str = "anthropic/claude-sonnet-4-20250514"):
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
cli_obj.model = model
|
|
cli_obj.session_start = datetime.now() - timedelta(minutes=14, seconds=32)
|
|
cli_obj.conversation_history = [{"role": "user", "content": "hi"}]
|
|
cli_obj.agent = None
|
|
return cli_obj
|
|
|
|
|
|
def _attach_goal(cli_obj, *, active: bool, turns_used: int = 3, max_turns: int = 20):
|
|
"""Bind a fake GoalManager the way _get_goal_manager caches one."""
|
|
cli_obj.session_id = "sess-goal-test"
|
|
cli_obj._goal_manager = SimpleNamespace(
|
|
session_id="sess-goal-test",
|
|
is_active=lambda: active,
|
|
state=SimpleNamespace(turns_used=turns_used, max_turns=max_turns),
|
|
)
|
|
return cli_obj
|
|
|
|
|
|
class TestStatusBarGoalSegment:
|
|
def test_goal_segment_composition(self):
|
|
cli_obj = _attach_goal(_make_cli(), active=True, turns_used=3, max_turns=20)
|
|
|
|
snapshot = cli_obj._get_status_bar_snapshot()
|
|
|
|
assert snapshot["goal_active"] is True
|
|
assert snapshot["goal_turns_used"] == 3
|
|
assert snapshot["goal_max_turns"] == 20
|
|
assert cli_obj._status_bar_goal_segment(snapshot) == "⊙ goal 3/20"
|
|
|
|
|
|
def test_goal_segment_absent_when_paused(self):
|
|
# Paused goals must NOT occupy the status bar (active-only contract).
|
|
cli_obj = _attach_goal(_make_cli(), active=False)
|
|
|
|
snapshot = cli_obj._get_status_bar_snapshot()
|
|
|
|
assert snapshot["goal_active"] is False
|
|
assert cli_obj._status_bar_goal_segment(snapshot) == ""
|
|
|
|
|
|
def test_active_goal_rendered_in_wide_status_bar(self):
|
|
cli_obj = _attach_goal(_make_cli(), active=True, turns_used=5, max_turns=20)
|
|
|
|
text = cli_obj._build_status_bar_text(width=120)
|
|
|
|
assert "⊙ goal 5/20" in text
|
|
|
|
def test_active_goal_rendered_in_medium_status_bar(self):
|
|
cli_obj = _attach_goal(_make_cli(), active=True, turns_used=1, max_turns=20)
|
|
|
|
text = cli_obj._build_status_bar_text(width=60)
|
|
|
|
assert "⊙ goal 1/20" in text
|
|
|
|
def test_active_goal_rendered_in_narrow_status_bar(self):
|
|
cli_obj = _attach_goal(_make_cli(), active=True, turns_used=2, max_turns=20)
|
|
|
|
text = cli_obj._build_status_bar_text(width=50)
|
|
|
|
assert "⊙ goal" in text
|
|
|