mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
52 lines
1.6 KiB
Python
52 lines
1.6 KiB
Python
"""Regression: auxiliary-client keepalive httpx client must honor custom CA bundles.
|
|
|
|
The main OpenAI client resolves per-provider ``ssl_ca_cert`` / ``ssl_verify`` and
|
|
``HERMES_CA_BUNDLE`` via ``agent.ssl_verify.resolve_httpx_verify``. Auxiliary calls
|
|
(compression, vision, web_extract, title generation, session_search) build their own
|
|
keepalive client through ``agent.process_bootstrap.build_keepalive_http_client`` and must
|
|
apply the same TLS settings — otherwise an HTTPS custom_providers endpoint signed by a
|
|
private CA works for chat but fails ``APIConnectionError`` on every auxiliary task.
|
|
"""
|
|
|
|
import ssl
|
|
|
|
import certifi
|
|
import httpx
|
|
import pytest
|
|
|
|
from agent.process_bootstrap import build_keepalive_http_client
|
|
|
|
_CA_ENV_VARS = ("HERMES_CA_BUNDLE", "SSL_CERT_FILE", "REQUESTS_CA_BUNDLE", "HTTPS_PROXY")
|
|
|
|
|
|
@pytest.fixture
|
|
def clean_tls_env(monkeypatch):
|
|
for var in _CA_ENV_VARS:
|
|
monkeypatch.delenv(var, raising=False)
|
|
|
|
|
|
def test_build_keepalive_http_client_forwards_verify_context(clean_tls_env):
|
|
ctx = ssl.create_default_context(cafile=certifi.where())
|
|
client = build_keepalive_http_client("https://ollama.example.com/v1", verify=ctx)
|
|
assert isinstance(client, httpx.Client)
|
|
assert client._transport._pool._ssl_context is ctx
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_resolve_aux_verify_ssl_verify_false(clean_tls_env, monkeypatch):
|
|
import hermes_cli.config as cfg
|
|
from agent import auxiliary_client
|
|
|
|
monkeypatch.setattr(
|
|
cfg,
|
|
"get_custom_provider_tls_settings",
|
|
lambda *a, **k: {"ssl_verify": False},
|
|
)
|
|
assert auxiliary_client._resolve_aux_verify("https://ollama.example.com/v1") is False
|
|
|
|
|