mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
96 lines
2.7 KiB
Python
96 lines
2.7 KiB
Python
"""Tests for service-singleton lifecycle: atexit handler, idempotent shutdown.
|
|
|
|
These cover the exit-cleanup behavior added to plug the language-server
|
|
process leak — without the atexit hook, ``hermes chat`` exits while
|
|
pyright/gopls/etc. are still alive on the host.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import atexit
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
from agent import lsp as lsp_module
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_singleton():
|
|
"""Force a clean module state before each test.
|
|
|
|
Tests in this file share process-global state (the lazy
|
|
singleton + atexit registration flag); reset both before and
|
|
after every test so order doesn't matter.
|
|
"""
|
|
lsp_module._service = None
|
|
lsp_module._atexit_registered = False
|
|
yield
|
|
lsp_module._service = None
|
|
lsp_module._atexit_registered = False
|
|
|
|
|
|
def test_get_service_registers_atexit_handler_once(monkeypatch):
|
|
"""First call to ``get_service`` must register an atexit handler;
|
|
subsequent calls must NOT register another one (Python's ``atexit``
|
|
runs every registered callable, so a duplicate would shutdown
|
|
twice — harmless but wasteful)."""
|
|
fake_svc = MagicMock()
|
|
fake_svc.is_active.return_value = True
|
|
monkeypatch.setattr(
|
|
lsp_module.LSPService, "create_from_config", classmethod(lambda cls: fake_svc)
|
|
)
|
|
|
|
registrations = []
|
|
|
|
def fake_register(fn):
|
|
registrations.append(fn)
|
|
|
|
monkeypatch.setattr(atexit, "register", fake_register)
|
|
|
|
a = lsp_module.get_service()
|
|
b = lsp_module.get_service()
|
|
c = lsp_module.get_service()
|
|
|
|
assert a is fake_svc
|
|
assert b is fake_svc
|
|
assert c is fake_svc
|
|
assert len(registrations) == 1
|
|
# The registered callable must be our internal shutdown wrapper.
|
|
assert registrations[0] is lsp_module._atexit_shutdown
|
|
|
|
|
|
|
|
|
|
def test_atexit_shutdown_swallows_exceptions(monkeypatch):
|
|
def boom():
|
|
raise RuntimeError("server already dead")
|
|
|
|
monkeypatch.setattr(lsp_module, "shutdown_service", boom)
|
|
# Must not raise.
|
|
lsp_module._atexit_shutdown()
|
|
|
|
|
|
def test_shutdown_service_idempotent(monkeypatch):
|
|
"""Calling shutdown twice must be safe — first call cleans up,
|
|
second call no-ops (nothing to shut down)."""
|
|
fake_svc = MagicMock()
|
|
fake_svc.is_active.return_value = True
|
|
fake_svc.shutdown = MagicMock()
|
|
monkeypatch.setattr(
|
|
lsp_module.LSPService, "create_from_config", classmethod(lambda cls: fake_svc)
|
|
)
|
|
monkeypatch.setattr(atexit, "register", lambda fn: None)
|
|
|
|
lsp_module.get_service()
|
|
lsp_module.shutdown_service()
|
|
lsp_module.shutdown_service() # must not raise
|
|
|
|
assert fake_svc.shutdown.call_count == 1
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|