mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
39 lines
1.3 KiB
Python
39 lines
1.3 KiB
Python
"""Regression: the ZIP-update directory replace must never leave a half-deleted tree.
|
|
|
|
Issue #49145: on Windows the ZIP-update path did ``rmtree(dst); copytree(...)``.
|
|
A copy that failed partway (file locks / flaky I/O — the very conditions the ZIP
|
|
path exists to work around) left the directory deleted with nothing copied back,
|
|
which broke ``hermes --tui`` because ``ui-tui/`` had vanished.
|
|
|
|
``_atomic_replace_dir`` stages the new copy first and only swaps it in on full
|
|
success, so a mid-copy failure leaves the original directory intact.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import shutil
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.main import _atomic_replace_dir
|
|
|
|
|
|
def test_atomic_replace_swaps_content_on_success(tmp_path: Path) -> None:
|
|
src = tmp_path / "src" / "ui-tui"
|
|
src.mkdir(parents=True)
|
|
(src / "new.txt").write_text("NEW")
|
|
|
|
dst = tmp_path / "install" / "ui-tui"
|
|
dst.mkdir(parents=True)
|
|
(dst / "old.txt").write_text("OLD")
|
|
|
|
_atomic_replace_dir(str(src), str(dst))
|
|
|
|
assert (dst / "new.txt").read_text() == "NEW"
|
|
assert not (dst / "old.txt").exists()
|
|
# No staging/backup siblings left behind.
|
|
assert not (dst.parent / "ui-tui.hermes-update-staging").exists()
|
|
assert not (dst.parent / "ui-tui.hermes-update-old").exists()
|
|
|
|
|