mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
85 lines
2.8 KiB
Python
85 lines
2.8 KiB
Python
"""Tests for `/exit --delete` and `/quit --delete` session deletion.
|
|
|
|
Ports the behavior from google-gemini/gemini-cli#19332: running `/exit` or
|
|
`/quit` with the `--delete` flag arms a one-shot `_delete_session_on_exit`
|
|
flag that the CLI shutdown path uses to remove the current session from
|
|
SQLite + on-disk transcripts before exit.
|
|
"""
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
def _make_cli():
|
|
"""Bare HermesCLI suitable for process_command() tests.
|
|
|
|
Uses ``__new__`` to skip the heavy __init__; only sets the attributes
|
|
the /exit branch touches.
|
|
"""
|
|
from cli import HermesCLI
|
|
cli = HermesCLI.__new__(HermesCLI)
|
|
cli.config = {}
|
|
cli.console = MagicMock()
|
|
cli.agent = None
|
|
cli.conversation_history = []
|
|
cli.session_id = "test-session"
|
|
cli._delete_session_on_exit = False
|
|
return cli
|
|
|
|
|
|
class TestExitDeleteFlag:
|
|
|
|
|
|
def test_exit_delete_arms_flag(self):
|
|
cli = _make_cli()
|
|
result = cli.process_command("/exit --delete")
|
|
assert result is False
|
|
assert cli._delete_session_on_exit is True
|
|
|
|
def test_quit_delete_arms_flag(self):
|
|
cli = _make_cli()
|
|
result = cli.process_command("/quit --delete")
|
|
assert result is False
|
|
assert cli._delete_session_on_exit is True
|
|
|
|
def test_exit_delete_short_form(self):
|
|
"""`-d` is a convenience alias for `--delete`."""
|
|
cli = _make_cli()
|
|
result = cli.process_command("/exit -d")
|
|
assert result is False
|
|
assert cli._delete_session_on_exit is True
|
|
|
|
|
|
|
|
def test_delete_flag_trims_whitespace(self):
|
|
cli = _make_cli()
|
|
result = cli.process_command("/exit --delete ")
|
|
assert result is False
|
|
assert cli._delete_session_on_exit is True
|
|
|
|
|
|
def test_unknown_exit_argument_prints_help(self):
|
|
cli = _make_cli()
|
|
# _cprint goes through module-level print, so capture via console.
|
|
# We can't patch _cprint directly without import juggling; the
|
|
# previous assertion already proves the unknown-arg branch is
|
|
# reached (result True + flag False).
|
|
result = cli.process_command("/exit garbage")
|
|
assert result is True
|
|
assert cli._delete_session_on_exit is False
|
|
|
|
|
|
class TestCommandRegistry:
|
|
def test_quit_command_advertises_delete_flag(self):
|
|
"""The CommandDef args_hint should surface `--delete` in /help and
|
|
CLI autocomplete."""
|
|
from hermes_cli.commands import resolve_command
|
|
cmd = resolve_command("quit")
|
|
assert cmd is not None
|
|
assert cmd.args_hint == "[--delete]"
|
|
|
|
def test_exit_alias_resolves_to_quit_with_hint(self):
|
|
from hermes_cli.commands import resolve_command
|
|
cmd = resolve_command("exit")
|
|
assert cmd is not None
|
|
assert cmd.name == "quit"
|
|
assert cmd.args_hint == "[--delete]"
|