mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
* test: make test env hermetic; enforce CI parity via scripts/run_tests.sh
Fixes the recurring 'works locally, fails in CI' (and vice versa) class
of flakes by making tests hermetic and providing a canonical local runner
that matches CI's environment.
## Layer 1 — hermetic conftest.py (tests/conftest.py)
Autouse fixture now unsets every credential-shaped env var before every
test, so developer-local API keys can't leak into tests that assert
'auto-detect provider when key present'.
Pattern: unset any var ending in _API_KEY, _TOKEN, _SECRET, _PASSWORD,
_CREDENTIALS, _ACCESS_KEY, _PRIVATE_KEY, etc. Plus an explicit list of
credential names that don't fit the suffix pattern (AWS_ACCESS_KEY_ID,
FAL_KEY, GH_TOKEN, etc.) and all the provider BASE_URL overrides that
change auto-detect behavior.
Also unsets HERMES_* behavioral vars (HERMES_YOLO_MODE, HERMES_QUIET,
HERMES_SESSION_*, etc.) that mutate agent behavior.
Also:
- Redirects HOME to a per-test tempdir (not just HERMES_HOME), so
code reading ~/.hermes/* directly can't touch the real dir.
- Pins TZ=UTC, LANG=C.UTF-8, LC_ALL=C.UTF-8, PYTHONHASHSEED=0 to
match CI's deterministic runtime.
The old _isolate_hermes_home fixture name is preserved as an alias so
any test that yields it explicitly still works.
## Layer 2 — scripts/run_tests.sh canonical runner
'Always use scripts/run_tests.sh, never call pytest directly' is the
new rule (documented in AGENTS.md). The script:
- Unsets all credential env vars (belt-and-suspenders for callers
who bypass conftest — e.g. IDE integrations)
- Pins TZ/LANG/PYTHONHASHSEED
- Uses -n 4 xdist workers (matches GHA ubuntu-latest; -n auto on
a 20-core workstation surfaces test-ordering flakes CI will never
see, causing the infamous 'passes in CI, fails locally' drift)
- Finds the venv in .venv, venv, or main checkout's venv
- Passes through arbitrary pytest args
Installs pytest-split on demand so the script can also be used to run
matrix-split subsets locally for debugging.
## Remove 3 module-level dotenv stubs that broke test isolation
tests/hermes_cli/test_{arcee,xiaomi,api_key}_provider.py each had a
module-level:
if 'dotenv' not in sys.modules:
fake_dotenv = types.ModuleType('dotenv')
fake_dotenv.load_dotenv = lambda *a, **kw: None
sys.modules['dotenv'] = fake_dotenv
This patches sys.modules['dotenv'] to a fake at import time with no
teardown. Under pytest-xdist LoadScheduling, whichever worker collected
one of these files first poisoned its sys.modules; subsequent tests in
the same worker that imported load_dotenv transitively (e.g.
test_env_loader.py via hermes_cli.env_loader) got the no-op lambda and
saw their assertions fail.
dotenv is a required dependency (python-dotenv>=1.2.1 in pyproject.toml),
so the defensive stub was never needed. Removed.
## Validation
- tests/hermes_cli/ alone: 2178 passed, 1 skipped, 0 failed (was 4
failures in test_env_loader.py before this fix)
- tests/test_plugin_skills.py, tests/hermes_cli/test_plugins.py,
tests/test_hermes_logging.py combined: 123 passed (the caplog
regression tests from PR #11453 still pass)
- Local full run shows no F/E clusters in the 0-55% range that were
previously present before the conftest hardening
## Background
See AGENTS.md 'Testing' section for the full list of drift sources
this closes. Matrix split (closed as #11566) will be re-attempted
once this foundation lands — cross-test pollution was the root cause
of the shard-3 hang in that PR.
* fix(conftest): don't redirect HOME — it broke CI subprocesses
PR #11577's autouse fixture was setting HOME to a per-test tempdir.
CI started timing out at 97% complete with dozens of E/F markers and
orphan python processes at cleanup — tests (or transitive deps)
spawn subprocesses that expect a stable HOME, and the redirect broke
them in non-obvious ways.
Env-var unsetting and TZ/LANG/hashseed pinning (the actual CI-drift
fixes) are unchanged and still in place. HERMES_HOME redirection is
also unchanged — that's the canonical way to isolate tests from
~/.hermes/, not HOME.
Any code in the codebase reading ~/.hermes/* via `Path.home() / ".hermes"`
instead of `get_hermes_home()` is a bug to fix at the callsite, not
something to paper over in conftest.
319 lines
12 KiB
Python
319 lines
12 KiB
Python
"""Tests for Xiaomi MiMo provider support."""
|
|
|
|
import os
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.auth import (
|
|
PROVIDER_REGISTRY,
|
|
resolve_provider,
|
|
get_api_key_provider_status,
|
|
resolve_api_key_provider_credentials,
|
|
AuthError,
|
|
)
|
|
|
|
|
|
# =============================================================================
|
|
# Provider Registry
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiProviderRegistry:
|
|
"""Verify Xiaomi is registered correctly in the PROVIDER_REGISTRY."""
|
|
|
|
def test_registered(self):
|
|
assert "xiaomi" in PROVIDER_REGISTRY
|
|
|
|
def test_name(self):
|
|
assert PROVIDER_REGISTRY["xiaomi"].name == "Xiaomi MiMo"
|
|
|
|
def test_auth_type(self):
|
|
assert PROVIDER_REGISTRY["xiaomi"].auth_type == "api_key"
|
|
|
|
def test_inference_base_url(self):
|
|
assert PROVIDER_REGISTRY["xiaomi"].inference_base_url == "https://api.xiaomimimo.com/v1"
|
|
|
|
def test_api_key_env_vars(self):
|
|
assert PROVIDER_REGISTRY["xiaomi"].api_key_env_vars == ("XIAOMI_API_KEY",)
|
|
|
|
def test_base_url_env_var(self):
|
|
assert PROVIDER_REGISTRY["xiaomi"].base_url_env_var == "XIAOMI_BASE_URL"
|
|
|
|
|
|
# =============================================================================
|
|
# Aliases
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiAliases:
|
|
"""All aliases should resolve to 'xiaomi'."""
|
|
|
|
@pytest.mark.parametrize("alias", [
|
|
"xiaomi", "mimo", "xiaomi-mimo",
|
|
])
|
|
def test_alias_resolves(self, alias, monkeypatch):
|
|
# Clear env to avoid auto-detection interfering
|
|
for key in ("XIAOMI_API_KEY",):
|
|
monkeypatch.delenv(key, raising=False)
|
|
monkeypatch.setenv("XIAOMI_API_KEY", "sk-test-key-12345678")
|
|
assert resolve_provider(alias) == "xiaomi"
|
|
|
|
def test_normalize_provider_models_py(self):
|
|
from hermes_cli.models import normalize_provider
|
|
assert normalize_provider("mimo") == "xiaomi"
|
|
assert normalize_provider("xiaomi-mimo") == "xiaomi"
|
|
|
|
def test_normalize_provider_providers_py(self):
|
|
from hermes_cli.providers import normalize_provider
|
|
assert normalize_provider("mimo") == "xiaomi"
|
|
assert normalize_provider("xiaomi-mimo") == "xiaomi"
|
|
|
|
|
|
# =============================================================================
|
|
# Auto-detection
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiAutoDetection:
|
|
"""Setting XIAOMI_API_KEY should auto-detect the provider."""
|
|
|
|
def test_auto_detect(self, monkeypatch):
|
|
# Clear all other provider env vars
|
|
for var in ("OPENROUTER_API_KEY", "OPENAI_API_KEY", "ANTHROPIC_API_KEY",
|
|
"DEEPSEEK_API_KEY", "GOOGLE_API_KEY", "GEMINI_API_KEY",
|
|
"DASHSCOPE_API_KEY", "XAI_API_KEY", "KIMI_API_KEY",
|
|
"MINIMAX_API_KEY", "AI_GATEWAY_API_KEY", "KILOCODE_API_KEY",
|
|
"HF_TOKEN", "GLM_API_KEY", "COPILOT_GITHUB_TOKEN",
|
|
"GH_TOKEN", "GITHUB_TOKEN", "MINIMAX_CN_API_KEY"):
|
|
monkeypatch.delenv(var, raising=False)
|
|
monkeypatch.setenv("XIAOMI_API_KEY", "sk-xiaomi-test-12345678")
|
|
provider = resolve_provider("auto")
|
|
assert provider == "xiaomi"
|
|
|
|
|
|
# =============================================================================
|
|
# Credentials
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiCredentials:
|
|
"""Test credential resolution for the xiaomi provider."""
|
|
|
|
def test_status_configured(self, monkeypatch):
|
|
monkeypatch.setenv("XIAOMI_API_KEY", "sk-test-12345678")
|
|
status = get_api_key_provider_status("xiaomi")
|
|
assert status["configured"]
|
|
|
|
def test_status_not_configured(self, monkeypatch):
|
|
monkeypatch.delenv("XIAOMI_API_KEY", raising=False)
|
|
status = get_api_key_provider_status("xiaomi")
|
|
assert not status["configured"]
|
|
|
|
def test_resolve_credentials(self, monkeypatch):
|
|
monkeypatch.setenv("XIAOMI_API_KEY", "sk-test-12345678")
|
|
monkeypatch.delenv("XIAOMI_BASE_URL", raising=False)
|
|
creds = resolve_api_key_provider_credentials("xiaomi")
|
|
assert creds["api_key"] == "sk-test-12345678"
|
|
assert creds["base_url"] == "https://api.xiaomimimo.com/v1"
|
|
|
|
def test_custom_base_url_override(self, monkeypatch):
|
|
monkeypatch.setenv("XIAOMI_API_KEY", "sk-test-12345678")
|
|
monkeypatch.setenv("XIAOMI_BASE_URL", "https://custom.xiaomi.example/v1")
|
|
creds = resolve_api_key_provider_credentials("xiaomi")
|
|
assert creds["base_url"] == "https://custom.xiaomi.example/v1"
|
|
|
|
|
|
# =============================================================================
|
|
# Model catalog (dynamic — no static list)
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiModelCatalog:
|
|
"""Xiaomi uses dynamic model discovery via models.dev."""
|
|
|
|
def test_models_dev_mapping(self):
|
|
from agent.models_dev import PROVIDER_TO_MODELS_DEV
|
|
assert PROVIDER_TO_MODELS_DEV["xiaomi"] == "xiaomi"
|
|
|
|
def test_static_model_list_fallback(self):
|
|
"""Static _PROVIDER_MODELS fallback must exist for model picker."""
|
|
from hermes_cli.models import _PROVIDER_MODELS
|
|
assert "xiaomi" in _PROVIDER_MODELS
|
|
models = _PROVIDER_MODELS["xiaomi"]
|
|
assert "mimo-v2-pro" in models
|
|
assert "mimo-v2-omni" in models
|
|
assert "mimo-v2-flash" in models
|
|
|
|
def test_list_agentic_models_mock(self, monkeypatch):
|
|
"""When models.dev returns Xiaomi data, list_agentic_models should return models."""
|
|
from agent import models_dev as md
|
|
|
|
fake_data = {
|
|
"xiaomi": {
|
|
"name": "Xiaomi",
|
|
"api": "https://api.xiaomimimo.com/v1",
|
|
"env": ["XIAOMI_API_KEY"],
|
|
"models": {
|
|
"mimo-v2-pro": {
|
|
"limit": {"context": 1000000},
|
|
"tool_call": True,
|
|
},
|
|
"mimo-v2-omni": {
|
|
"limit": {"context": 256000},
|
|
"tool_call": True,
|
|
},
|
|
"mimo-v2-flash": {
|
|
"limit": {"context": 256000},
|
|
"tool_call": True,
|
|
},
|
|
},
|
|
}
|
|
}
|
|
monkeypatch.setattr(md, "fetch_models_dev", lambda: fake_data)
|
|
|
|
result = md.list_agentic_models("xiaomi")
|
|
assert "mimo-v2-pro" in result
|
|
assert "mimo-v2-flash" in result
|
|
|
|
|
|
# =============================================================================
|
|
# Normalization
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiNormalization:
|
|
"""Model name normalization — Xiaomi is a direct provider."""
|
|
|
|
def test_vendor_prefix_mapping(self):
|
|
from hermes_cli.model_normalize import _VENDOR_PREFIXES
|
|
assert _VENDOR_PREFIXES.get("mimo") == "xiaomi"
|
|
|
|
def test_matching_prefix_strip(self):
|
|
"""xiaomi/mimo-v2-pro should normalize to mimo-v2-pro for direct API."""
|
|
from hermes_cli.model_normalize import _MATCHING_PREFIX_STRIP_PROVIDERS
|
|
assert "xiaomi" in _MATCHING_PREFIX_STRIP_PROVIDERS
|
|
|
|
def test_normalize_strips_provider_prefix(self):
|
|
from hermes_cli.model_normalize import normalize_model_for_provider
|
|
result = normalize_model_for_provider("xiaomi/mimo-v2-pro", "xiaomi")
|
|
assert result == "mimo-v2-pro"
|
|
|
|
def test_normalize_bare_name_unchanged(self):
|
|
from hermes_cli.model_normalize import normalize_model_for_provider
|
|
result = normalize_model_for_provider("mimo-v2-pro", "xiaomi")
|
|
assert result == "mimo-v2-pro"
|
|
|
|
|
|
# =============================================================================
|
|
# URL mapping
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiURLMapping:
|
|
"""Test URL → provider inference for Xiaomi endpoints."""
|
|
|
|
def test_url_to_provider(self):
|
|
from agent.model_metadata import _URL_TO_PROVIDER
|
|
assert _URL_TO_PROVIDER.get("api.xiaomimimo.com") == "xiaomi"
|
|
|
|
def test_provider_prefixes(self):
|
|
from agent.model_metadata import _PROVIDER_PREFIXES
|
|
assert "xiaomi" in _PROVIDER_PREFIXES
|
|
assert "mimo" in _PROVIDER_PREFIXES
|
|
assert "xiaomi-mimo" in _PROVIDER_PREFIXES
|
|
|
|
def test_infer_from_url(self):
|
|
from agent.model_metadata import _infer_provider_from_url
|
|
assert _infer_provider_from_url("https://api.xiaomimimo.com/v1") == "xiaomi"
|
|
|
|
def test_infer_from_regional_urls(self):
|
|
"""Regional token-plan endpoints should also resolve to xiaomi."""
|
|
from agent.model_metadata import _infer_provider_from_url
|
|
assert _infer_provider_from_url("https://token-plan-ams.xiaomimimo.com/v1") == "xiaomi"
|
|
assert _infer_provider_from_url("https://token-plan-cn.xiaomimimo.com/v1") == "xiaomi"
|
|
assert _infer_provider_from_url("https://token-plan-sgp.xiaomimimo.com/v1") == "xiaomi"
|
|
|
|
|
|
# =============================================================================
|
|
# providers.py
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiProvidersModule:
|
|
"""Test Xiaomi in the unified providers module."""
|
|
|
|
def test_overlay_exists(self):
|
|
from hermes_cli.providers import HERMES_OVERLAYS
|
|
assert "xiaomi" in HERMES_OVERLAYS
|
|
overlay = HERMES_OVERLAYS["xiaomi"]
|
|
assert overlay.transport == "openai_chat"
|
|
assert overlay.base_url_env_var == "XIAOMI_BASE_URL"
|
|
assert not overlay.is_aggregator
|
|
|
|
def test_alias_resolves(self):
|
|
from hermes_cli.providers import normalize_provider
|
|
assert normalize_provider("mimo") == "xiaomi"
|
|
assert normalize_provider("xiaomi-mimo") == "xiaomi"
|
|
|
|
def test_label(self):
|
|
from hermes_cli.providers import get_label
|
|
assert get_label("xiaomi") == "Xiaomi MiMo"
|
|
|
|
def test_get_provider(self):
|
|
pdef = None
|
|
try:
|
|
from hermes_cli.providers import get_provider
|
|
pdef = get_provider("xiaomi")
|
|
except Exception:
|
|
pass
|
|
if pdef is not None:
|
|
assert pdef.id == "xiaomi"
|
|
assert pdef.transport == "openai_chat"
|
|
|
|
|
|
# =============================================================================
|
|
# Auxiliary client
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiAuxiliary:
|
|
"""Xiaomi auxiliary routing: vision → omni, non-vision → user's main model, never flash."""
|
|
|
|
def test_no_flash_in_aux_models(self):
|
|
"""mimo-v2-flash must NEVER be used for automatic aux routing."""
|
|
from agent.auxiliary_client import _API_KEY_PROVIDER_AUX_MODELS
|
|
assert "xiaomi" not in _API_KEY_PROVIDER_AUX_MODELS
|
|
|
|
def test_vision_model_override(self):
|
|
"""Xiaomi vision tasks should use mimo-v2-omni (multimodal), not the main model."""
|
|
from agent.auxiliary_client import _PROVIDER_VISION_MODELS
|
|
assert "xiaomi" in _PROVIDER_VISION_MODELS
|
|
assert _PROVIDER_VISION_MODELS["xiaomi"] == "mimo-v2-omni"
|
|
|
|
|
|
# =============================================================================
|
|
# Agent init (no SyntaxError, correct api_mode)
|
|
# =============================================================================
|
|
|
|
|
|
class TestXiaomiDoctor:
|
|
"""Verify hermes doctor recognizes Xiaomi env vars."""
|
|
|
|
def test_provider_env_hints(self):
|
|
from hermes_cli.doctor import _PROVIDER_ENV_HINTS
|
|
assert "XIAOMI_API_KEY" in _PROVIDER_ENV_HINTS
|
|
|
|
|
|
class TestXiaomiAgentInit:
|
|
"""Verify the agent can be constructed with xiaomi provider without errors."""
|
|
|
|
def test_no_syntax_errors(self):
|
|
"""Importing run_agent with xiaomi should not raise."""
|
|
import importlib
|
|
importlib.import_module("run_agent")
|
|
|
|
def test_api_mode_is_chat_completions(self):
|
|
from hermes_cli.providers import HERMES_OVERLAYS, TRANSPORT_TO_API_MODE
|
|
overlay = HERMES_OVERLAYS["xiaomi"]
|
|
api_mode = TRANSPORT_TO_API_MODE[overlay.transport]
|
|
assert api_mode == "chat_completions"
|