mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-26 17:38:36 +00:00
b9f82ed39f
Replace the static comment-pending + comment-results two-job pattern
with a live-updating comment system that polls the GitHub Actions API
every 15s, re-assembles the review comment from whatever results are
available, and upserts it via the <!-- hermes-ci-review-bot --> marker.
The comment updates in real time as each job finishes — no waiting for
the full pipeline.
Every CI job that wants to appear in the review comment emits a
review_status output — a JSON array of objects, each with a source
and a results array:
[
{
"source": "review-label-gate",
"results": [
{"kind": "action_required", "title": "...", "summary": "...",
"how_to_fix": "..."},
{"kind": "info", "title": "...", "summary": "..."}
]
},
{
"source": "ci timing",
"results": [
{"kind": "warning", "title": "CI timings", "summary": "...",
"detail": "...", "link": "..."}
]
}
]
One job can emit multiple results of different kinds. The source field
is used to exclude the corresponding job from the synthesized error
list (case-insensitive, hyphen-normalized matching against GitHub
Actions job display names).
| job | source | kind (on failure) | section |
|----------------------------|--------------------------|---------------------------|----------------------|
| review-labels | review label gate | action_required / info | Action required |
| lockfile-diff | lockfile-diff | action_required | Action required |
| ci-timings | ci timing | warning / info | Warnings |
| supply-chain scan | supply chain | error / (none) | Job failures |
| supply-chain dep-bounds | supply chain | action_required / (none) | Action required |
| osv-scanner | osv scan | warning / (none) | Warnings |
| uv-lockfile-check | uv.lock check | action_required / (none) | Action required |
| history-check | unrelated histories | action_required | Action required |
| contributor-check | contributor attribution | action_required | Action required |
Jobs that find nothing emit [] (empty array) — no noise info items.
A single comment-live job polls the GitHub Actions API every 15s,
classifies jobs into (completed, pending), assembles the comment, and
upserts it. Merges review_status outputs from all needs jobs via
toJSON(needs.*.outputs.review_status), and downloads the ci-timings
artifact when it becomes available. Shows commit SHA + message below
the header.
The assembler has ZERO job-specific knowledge. It just:
1. collect_from_statuses() — flattens all nested status objects into ReviewItems
2. collect_failed_jobs() — synthesizes errors for failed jobs with no declared status
3. _attach_job_urls() — fills in per-job log links for ALL items
4. render_comment() — groups by severity, renders with group headers
Each item shows links inline next to the title: View report (job-emitted
URL) and View job (auto-attached logs link). Each info item is its own
collapsible <details> block.
# ૮ >ﻌ< ა ci review
running on abc1234 — commit message first line
## ❌ Job failures
### {title} · [View job](url)
{summary}
## ⚠️ Action required
### {title} · [View job](url)
{summary}
**How to fix:**
{how_to_fix}
## ⚠️ Warnings
### {title} · [View report](url) · [View job](url)
{summary}
{detail}
<details><summary>{title}</summary>
{content}
</details>
Still running 3 jobs: ci-timings, docker
- test_assemble_review_comment.py (48 tests): collect_from_statuses,
collect_failed_jobs with exclude_sources, _attach_job_urls,
render_comment (group headers, inline links, commit info, per-item
details, pending footer), assemble integration
- test_live_comment.py (16 tests): classify_jobs pure function
- test_timings_report.py (10 tests): generate_review_status nested format
- test_lockfile_diff.py (6 tests)
- test_classify_changes.py (32 tests, pre-existing)
92 lines
3.4 KiB
YAML
92 lines
3.4 KiB
YAML
name: Review labels
|
|
|
|
# Require explicit maintainer review when CI-sensitive files or the MCP
|
|
# catalog change. Previously this was split across two jobs in two
|
|
# workflows: ``ci-review`` in lint.yml (gated on ``ci_review``) and
|
|
# ``mcp-catalog-review`` in supply-chain-audit.yml (gated on
|
|
# ``mcp_catalog``). Both checked for their own label.
|
|
#
|
|
# Now consolidated: a single ``ci-reviewed`` label covers both. The
|
|
# comment sections tell the reviewer exactly what to verify per area,
|
|
# so one label is enough — the human reads the comment, not the label
|
|
# name.
|
|
#
|
|
# Outputs:
|
|
# ci_reviewed — "true" / "false" / "" (empty when neither lane ran)
|
|
# review_status — JSON array of status objects consumed by the review
|
|
# comment assembler. See scripts/ci/emit_review_status.py.
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
ci_review:
|
|
description: Whether CI-sensitive files (eslint config, workflows, actions) changed.
|
|
type: boolean
|
|
default: false
|
|
mcp_catalog:
|
|
description: Whether the MCP catalog / installer changed.
|
|
type: boolean
|
|
default: false
|
|
outputs:
|
|
ci_reviewed:
|
|
description: Whether the ci-reviewed label is present. Empty when neither input was true.
|
|
value: ${{ jobs.check.outputs.ci_reviewed }}
|
|
review_status:
|
|
description: JSON array of status objects for the review comment assembler.
|
|
value: ${{ jobs.check.outputs.review_status }}
|
|
|
|
permissions:
|
|
contents: read
|
|
pull-requests: read # read PR labels
|
|
|
|
jobs:
|
|
check:
|
|
name: Review label gate
|
|
if: inputs.ci_review || inputs.mcp_catalog
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 2
|
|
outputs:
|
|
ci_reviewed: ${{ steps.label-check.outputs.ci_reviewed }}
|
|
review_status: ${{ steps.build-status.outputs.review_status }}
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
|
|
- name: Check ci-reviewed label
|
|
id: label-check
|
|
env:
|
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
REPO: ${{ github.repository }}
|
|
run: |
|
|
set -euo pipefail
|
|
PR="${{ github.event.pull_request.number }}"
|
|
LABELS=$(gh pr view "$PR" --repo "$REPO" --json labels --jq '.labels[].name' || true)
|
|
|
|
if echo "$LABELS" | grep -Fxq 'ci-reviewed'; then
|
|
echo "ci-reviewed label present."
|
|
echo "ci_reviewed=true" >> "$GITHUB_OUTPUT"
|
|
else
|
|
echo "ci-reviewed label missing."
|
|
echo "ci_reviewed=false" >> "$GITHUB_OUTPUT"
|
|
fi
|
|
|
|
- name: Build review_status JSON
|
|
id: build-status
|
|
env:
|
|
CI_REVIEW: ${{ inputs.ci_review }}
|
|
MCP_CATALOG: ${{ inputs.mcp_catalog }}
|
|
LABEL_PRESENT: ${{ steps.label-check.outputs.ci_reviewed }}
|
|
run: |
|
|
set -euo pipefail
|
|
ARGS=""
|
|
if [ "$CI_REVIEW" = "true" ]; then ARGS="$ARGS --ci-review"; fi
|
|
if [ "$MCP_CATALOG" = "true" ]; then ARGS="$ARGS --mcp-catalog"; fi
|
|
if [ "$LABEL_PRESENT" = "true" ]; then ARGS="$ARGS --label-present"; fi
|
|
|
|
python3 scripts/ci/emit_review_status.py $ARGS --output "$GITHUB_OUTPUT"
|
|
|
|
- name: Fail on missing label
|
|
if: steps.label-check.outputs.ci_reviewed != 'true'
|
|
run: |
|
|
echo "::error::CI-sensitive changes require the ci-reviewed label. Add the label and re-run this check."
|
|
exit 1
|