mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
39 lines
1.4 KiB
Python
39 lines
1.4 KiB
Python
"""Tests for _resolve_path() — TERMINAL_CWD-aware path resolution in file_tools."""
|
|
|
|
import os
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
|
|
class TestResolvePath:
|
|
"""Verify _resolve_path respects TERMINAL_CWD for worktree isolation."""
|
|
|
|
def test_relative_path_uses_terminal_cwd(self, monkeypatch, tmp_path):
|
|
"""Relative paths resolve against TERMINAL_CWD, not process CWD."""
|
|
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path))
|
|
from tools.file_tools import _resolve_path
|
|
|
|
result = _resolve_path("foo/bar.py")
|
|
assert result == (tmp_path / "foo" / "bar.py")
|
|
|
|
|
|
def test_relative_path_prefers_recorded_session_cwd(self, monkeypatch, tmp_path):
|
|
"""The session's recorded cwd must win after the terminal changes directory."""
|
|
start_dir = tmp_path / "start"
|
|
live_dir = tmp_path / "worktree"
|
|
start_dir.mkdir()
|
|
live_dir.mkdir()
|
|
monkeypatch.setenv("TERMINAL_CWD", str(start_dir))
|
|
|
|
from tools import file_tools, terminal_tool
|
|
|
|
task_id = "live-cwd"
|
|
# The session's completed `cd` recorded the new directory.
|
|
terminal_tool.record_session_cwd(task_id, str(live_dir))
|
|
|
|
try:
|
|
result = file_tools._resolve_path("nested/file.txt", task_id=task_id)
|
|
finally:
|
|
terminal_tool.clear_session_cwd(task_id)
|
|
|
|
assert result == live_dir / "nested" / "file.txt"
|