mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Adds test_moa_gemini_aggregator_sanitize_uses_real_model: drives a full MoA tool-call turn (virtual-provider mode) with a Gemini aggregator and asserts the strict-API sanitize pass is invoked with the resolved aggregator model (gemini-3-pro-preview), never the virtual preset name once a slot is resolved — the exact path that stripped extra_content/thought_signature and made Gemini aggregators 400 (#65092). Writing the test surfaced a gap in the salvaged #66212 fix: in virtual- provider MoA mode (provider=moa, no moa_config threaded through run_conversation) the conversation-loop branch never fired because it only consulted moa_config. Extend it to fall back to the facade's last_aggregator_slot — the same source the handle_max_iterations fix uses — so both MoA entry modes resolve the real aggregator model. Also adds the contributors/emails mapping for the #15676 credit base. |
||
|---|---|---|
| .. | ||
| emails | ||
| README.md | ||
Contributor email → GitHub login mappings
This directory replaces appending entries to AUTHOR_MAP in
scripts/release.py. The old dict caused constant merge conflicts when
several salvage PRs landed at once — every PR edited the same lines of the
same file. Here, each mapping is its own file, and file additions never
conflict.
Adding a mapping
One file per commit-author email, under emails/:
python3 scripts/add_contributor.py <email> <github-login>
# or by hand:
echo "<github-login>" > contributors/emails/<email>
- File name = the exact commit-author email (as shown by
git log --format='%ae'). - File content = the GitHub login on the first non-comment line.
Lines starting with
#are comments (use them for the PR reference).
Example — contributors/emails/jane.doe@example.com:
janedoe
# PR #12345 salvage (gateway: fix session key routing)
Rules
- Do NOT add new entries to
AUTHOR_MAPinscripts/release.py. That dict is frozen legacy data; the release tooling merges it with this directory (directory entries win on duplicates). - GitHub noreply emails (
<id>+<login>@users.noreply.github.comand<login>@users.noreply.github.com) auto-resolve — no file needed. - The
Contributor Attribution CheckCI job fails a PR whose commits carry an unmapped email; the failure message prints the exact command to run.