mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-24 10:52:21 +00:00
e5e2583635
On a Linux source install the in-app updater ran the full backend update +
desktop rebuild successfully but never restarted the app — it hung forever on
the applying overlay with no close button. Two causes:
- applyUpdatesPosixInApp() only handled the macOS .app bundle swap;
runningAppBundle() is null off macOS, so Linux fell through to
{ ok: true, backendUpdated: true } without ever relaunching.
- The renderer store had no terminal state for that result shape, so
$updateApply stayed { applying: true } and the overlay's close button
(hidden while applying) never appeared.
Fix (new electron/update-relaunch.cjs, pure + unit-tested):
- Decide the Linux outcome from whether the *running* binary is the one we
just rebuilt (execPath under release/<plat>-unpacked, path-segment-aware so
linux-unpacked-evil can't masquerade) and whether its chrome-sandbox helper
is launchable (root:root + setuid, or an --no-sandbox / ELECTRON_DISABLE_SANDBOX
opt-out):
relaunch — detached watcher waits for this PID to exit (graceful, then
SIGKILL), self-deletes, and re-execs the rebuilt binary with the original
launch context (filtered args + HERMES_*/sandbox env + cwd) restored.
guiSkew — AppImage/.deb/.rpm/dev: backend updated but this GUI package was
NOT changed; surface an honest closeable 'reinstall the desktop app'
terminal state instead of lying that it loads next launch (#37541 skew).
manual — rebuilt binary but sandbox helper not launchable: keep the
working window, don't quit into a dead app.
- store/updates.ts lands a terminal, closeable state for EVERY resolved apply
outcome (handedOff / guiSkew / manualRestart / updated-not-relaunched / error)
so the hang is impossible regardless of platform or result.
- New DesktopUpdateStage values (update/rebuild/done/guiSkew) + GuiSkewView so
progress reads correctly and the skew state is closeable. i18n in all four
locales (en/ja/zh/zh-hant) in parity.
- electron/update-relaunch.test.cjs (16 tests) + store outcome tests.
Salvaged from #45205 onto current main. Linux quit dwell uses the shared
UPDATE_HANDOFF_DWELL_MS (2.5s) from #50448 for consistency. Four-locale i18n
parity, AUTHOR_MAP entry, and the test wiring added on top.
Closes #45205.
|
||
|---|---|---|
| .. | ||
| backend-env.cjs | ||
| backend-env.test.cjs | ||
| backend-probes.cjs | ||
| backend-probes.test.cjs | ||
| backend-ready.cjs | ||
| backend-ready.test.cjs | ||
| bootstrap-platform.cjs | ||
| bootstrap-platform.test.cjs | ||
| bootstrap-runner.cjs | ||
| bootstrap-runner.test.cjs | ||
| connection-config.cjs | ||
| connection-config.test.cjs | ||
| dashboard-token.cjs | ||
| dashboard-token.test.cjs | ||
| desktop-uninstall.cjs | ||
| desktop-uninstall.test.cjs | ||
| entitlements.mac.inherit.plist | ||
| entitlements.mac.plist | ||
| fs-read-dir.cjs | ||
| fs-read-dir.test.cjs | ||
| gateway-ws-probe.cjs | ||
| gateway-ws-probe.test.cjs | ||
| git-root.cjs | ||
| git-root.test.cjs | ||
| git-worktrees.cjs | ||
| hardening.cjs | ||
| hardening.test.cjs | ||
| link-title-window.cjs | ||
| link-title-window.test.cjs | ||
| main.cjs | ||
| oauth-net-request.cjs | ||
| oauth-net-request.test.cjs | ||
| preload.cjs | ||
| session-windows.cjs | ||
| session-windows.test.cjs | ||
| update-marker.cjs | ||
| update-marker.test.cjs | ||
| update-rebuild.cjs | ||
| update-rebuild.test.cjs | ||
| update-relaunch.cjs | ||
| update-relaunch.test.cjs | ||
| update-remote.cjs | ||
| update-remote.test.cjs | ||
| vscode-marketplace.cjs | ||
| vscode-marketplace.test.cjs | ||
| windows-child-process.test.cjs | ||
| windows-user-env.cjs | ||
| windows-user-env.test.cjs | ||
| workspace-cwd.cjs | ||
| workspace-cwd.test.cjs | ||