mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-10 13:31:38 +00:00
1f1d346ced
The inbound-media validator _is_allowed_bridge_path() checked against IMAGE_CACHE_DIR / AUDIO_CACHE_DIR / VIDEO_CACHE_DIR / DOCUMENT_CACHE_DIR value-imported at module load. After the base.py cache-dir getters became per-call resolvers, the bridge writes media into the active profile's cache while the validator still matched the frozen launch-profile constants — so media was rejected under a profile override (multi-profile gateway). Resolve the cache roots per-call via the get_*_cache_dir() getters and drop the now-unused frozen value-imports. Caught by automated review on #55867.
67 lines
2.5 KiB
Python
67 lines
2.5 KiB
Python
"""Regression: the WhatsApp inbound-media path validator follows the active
|
|
profile override.
|
|
|
|
The bridge writes inbound media into the active profile's cache (resolved via
|
|
get_image_cache_dir() etc.). _is_allowed_bridge_path() validates those paths.
|
|
It previously checked against IMAGE_CACHE_DIR / AUDIO_CACHE_DIR module
|
|
constants value-imported at import time, so under a profile override the
|
|
validator rejected media the bridge had legitimately written into the override
|
|
profile's cache. The validator must resolve the cache roots per-call.
|
|
"""
|
|
from pathlib import Path
|
|
|
|
from hermes_constants import reset_hermes_home_override, set_hermes_home_override
|
|
|
|
|
|
def _make_profile(root: Path) -> Path:
|
|
for sub in ("cache/images", "cache/audio", "cache/videos", "cache/documents"):
|
|
(root / sub).mkdir(parents=True, exist_ok=True)
|
|
return root
|
|
|
|
|
|
def test_validator_accepts_active_profile_media(tmp_path):
|
|
from plugins.platforms.whatsapp.adapter import _is_allowed_bridge_path
|
|
|
|
prof = _make_profile(tmp_path / "profB")
|
|
media = prof / "cache" / "images" / "img_abc.jpg"
|
|
media.write_bytes(b"\xff\xd8\xff\x00")
|
|
|
|
token = set_hermes_home_override(str(prof))
|
|
try:
|
|
assert _is_allowed_bridge_path(str(media)) is True
|
|
finally:
|
|
reset_hermes_home_override(token)
|
|
|
|
|
|
def test_validator_follows_override_switch(tmp_path):
|
|
"""A path under profile A is rejected while the override is profile B."""
|
|
from plugins.platforms.whatsapp.adapter import _is_allowed_bridge_path
|
|
|
|
prof_a = _make_profile(tmp_path / "profA")
|
|
prof_b = _make_profile(tmp_path / "profB")
|
|
a_media = prof_a / "cache" / "images" / "img_a.jpg"
|
|
a_media.write_bytes(b"\xff\xd8\xff\x00")
|
|
|
|
# Under B, B's own media validates...
|
|
b_media = prof_b / "cache" / "images" / "img_b.jpg"
|
|
b_media.write_bytes(b"\xff\xd8\xff\x00")
|
|
token = set_hermes_home_override(str(prof_b))
|
|
try:
|
|
assert _is_allowed_bridge_path(str(b_media)) is True
|
|
# ...and a path from a *different* profile is not in B's cache roots.
|
|
assert _is_allowed_bridge_path(str(a_media)) is False
|
|
finally:
|
|
reset_hermes_home_override(token)
|
|
|
|
|
|
def test_validator_rejects_non_cache_path(tmp_path):
|
|
from plugins.platforms.whatsapp.adapter import _is_allowed_bridge_path
|
|
|
|
prof = _make_profile(tmp_path / "profB")
|
|
outside = tmp_path / "etc_passwd"
|
|
outside.write_text("root:x:0:0")
|
|
token = set_hermes_home_override(str(prof))
|
|
try:
|
|
assert _is_allowed_bridge_path(str(outside)) is False
|
|
finally:
|
|
reset_hermes_home_override(token)
|