mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-15 14:22:43 +00:00
a0a6cd80f5
* fix(agent): persist truthful tool effect dispositions * fix(agent): preserve successful siblings during orphan recovery * fix(agent): narrow effect dispositions to none and unknown
43 lines
1.4 KiB
Python
43 lines
1.4 KiB
Python
"""Tests for shared tool result classification helpers."""
|
|
|
|
import json
|
|
|
|
from agent.tool_result_classification import (
|
|
file_mutation_result_landed,
|
|
)
|
|
|
|
|
|
def test_write_file_with_nested_lint_error_counts_as_landed():
|
|
result = json.dumps({
|
|
"bytes_written": 12,
|
|
"lint": {"status": "error", "output": "SyntaxError: invalid syntax"},
|
|
})
|
|
|
|
assert file_mutation_result_landed("write_file", result) is True
|
|
|
|
|
|
def test_patch_with_nested_lsp_diagnostics_counts_as_landed():
|
|
result = json.dumps({
|
|
"success": True,
|
|
"diff": "--- a/tmp.py\n+++ b/tmp.py\n",
|
|
"lsp_diagnostics": "<diagnostics>ERROR [1:1] type mismatch</diagnostics>",
|
|
})
|
|
|
|
assert file_mutation_result_landed("patch", result) is True
|
|
|
|
|
|
def test_top_level_file_mutation_error_does_not_count_as_landed():
|
|
result = json.dumps({"success": True, "error": "post-write verification failed"})
|
|
|
|
assert file_mutation_result_landed("patch", result) is False
|
|
|
|
|
|
def test_side_effect_classification_keeps_session_mutations():
|
|
from agent.tool_result_classification import tool_may_have_side_effect
|
|
|
|
assert tool_may_have_side_effect("todo") is True
|
|
assert tool_may_have_side_effect("memory") is True
|
|
assert tool_may_have_side_effect("write_file") is True
|
|
assert tool_may_have_side_effect("mcp_unknown") is True
|
|
assert tool_may_have_side_effect("read_file") is False
|
|
assert tool_may_have_side_effect("web_search") is False
|