mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-13 09:01:54 +00:00
1e25358a8f
Replace the PortPool-based port reservation system (9120-9199 range) with OS-assigned ephemeral ports via --port 0. Before: Desktop probed a hardcoded port range, reserved ports in-process to close TOCTOU races, and passed the chosen port to the dashboard via CLI arg. After: Desktop spawns dashboard with --port 0, parses the actual port from a stdout announcement line (HERMES_DASHBOARD_READY port=<N>), and uses that for WebSocket connections. Changes: - web_server.py: add --port 0 support with SO_REUSEADDR pre-bind + announcement; add EADDRINUSE preflight for explicit ports - main.cjs: remove PortPool, PORT_FLOOR/CEILING, pickPort(), isPortAvailable(); add waitForDashboardPort() stdout parser - Delete port-pool.cjs and port-pool.test.cjs (106 lines removed) Net effect: eliminates the entire TOCTOU-mitigation reservation infrastructure and arbitrary port range constraints. OS handles port allocation natively.
77 lines
2 KiB
Python
77 lines
2 KiB
Python
"""Test that start_server configures ws-ping keepalive.
|
|
|
|
The server now uses uvicorn.Server directly (not uvicorn.run) so we stub
|
|
Config + Server + asyncio.run to capture kwargs without starting an event loop.
|
|
"""
|
|
|
|
import asyncio
|
|
import contextlib
|
|
|
|
import uvicorn
|
|
|
|
from hermes_cli import web_server
|
|
|
|
|
|
def _stub_uvicorn(monkeypatch):
|
|
"""Replace uvicorn.Config/Server with fakes so start_server returns
|
|
immediately. Returns a dict with captured Config kwargs."""
|
|
captured: dict = {}
|
|
|
|
class _FakeConfig:
|
|
loaded = True
|
|
host = "127.0.0.1"
|
|
port = 8000
|
|
|
|
def __init__(self, *args, **kwargs):
|
|
captured.update(kwargs)
|
|
|
|
def load(self):
|
|
pass
|
|
|
|
class lifespan_class:
|
|
should_exit = False
|
|
state: dict = {}
|
|
|
|
def __init__(self, *a, **kw):
|
|
pass
|
|
|
|
async def startup(self):
|
|
pass
|
|
|
|
async def shutdown(self):
|
|
pass
|
|
|
|
class _FakeServer:
|
|
should_exit = False
|
|
started = True
|
|
servers: list = []
|
|
lifespan = None
|
|
|
|
@staticmethod
|
|
def capture_signals():
|
|
return contextlib.nullcontext()
|
|
|
|
async def startup(self, sockets=None):
|
|
pass
|
|
|
|
async def main_loop(self):
|
|
pass
|
|
|
|
async def shutdown(self, sockets=None):
|
|
pass
|
|
|
|
monkeypatch.setattr(uvicorn, "Config", _FakeConfig)
|
|
monkeypatch.setattr(uvicorn, "Server", lambda config: _FakeServer())
|
|
return captured
|
|
|
|
|
|
def test_start_server_enables_ws_ping_for_half_open_detection(monkeypatch):
|
|
"""WS ping must be configured so half-open connections (reverse-proxy 524,
|
|
dropped tunnels) raise WebSocketDisconnect into the reaping path (#32377)."""
|
|
captured = _stub_uvicorn(monkeypatch)
|
|
|
|
# Loopback bind => no auth gate, so this reaches the Config constructor.
|
|
web_server.start_server(host="127.0.0.1", port=0, open_browser=False)
|
|
|
|
assert captured["ws_ping_interval"] == 20.0
|
|
assert captured["ws_ping_timeout"] == 20.0
|