hermes-agent/tests/agent/test_moa_reasoning_effort.py

from types import SimpleNamespace
from unittest.mock import patch



def _response(content="ok"):
    message = SimpleNamespace(content=content, tool_calls=[])
    choice = SimpleNamespace(message=message, finish_reason="stop")
    return SimpleNamespace(choices=[choice], usage=None, model="fake")



def test_slot_label_includes_reasoning_effort():
    from agent.moa_loop import _slot_label

    assert _slot_label(
        {"provider": "openai-codex", "model": "gpt-5.6-sol", "reasoning_effort": "xhigh"}
    ) == "openai-codex:gpt-5.6-sol[reasoning=xhigh]"



def test_slot_reasoning_config_parses_effort_and_none():
    from agent.moa_loop import _slot_reasoning_config

    assert _slot_reasoning_config({"reasoning_effort": "high"}) == {
        "enabled": True,
        "effort": "high",
    }
    assert _slot_reasoning_config({"reasoning_effort": "none"}) == {"enabled": False}
    assert _slot_reasoning_config({}) is None



def test_moa_reference_passes_per_slot_reasoning_config(monkeypatch):
    from agent.moa_loop import _run_reference

    captured = {}

    def fake_call_llm(**kwargs):
        captured.update(kwargs)
        return _response("advice")

    monkeypatch.setattr("agent.moa_loop.call_llm", fake_call_llm)
    with patch("hermes_cli.runtime_provider.resolve_runtime_provider") as mock_resolve:
        mock_resolve.return_value = {"provider": "openai-codex", "model": "gpt-5.6-sol"}
        _run_reference(
            {"provider": "openai-codex", "model": "gpt-5.6-sol", "reasoning_effort": "low"},
            [{"role": "user", "content": "judge this"}],
        )

    assert captured["reasoning_config"] == {"enabled": True, "effort": "low"}



def test_call_llm_builder_translates_reasoning_config_to_extra_body():
    from agent.auxiliary_client import _build_call_kwargs

    kwargs = _build_call_kwargs(
        "openai-codex",
        "gpt-5.6-sol",
        [{"role": "user", "content": "hi"}],
        reasoning_config={"enabled": True, "effort": "xhigh"},
    )
    assert kwargs["extra_body"]["reasoning"] == {"enabled": True, "effort": "xhigh"}

    off = _build_call_kwargs(
        "openai-codex",
        "gpt-5.6-sol",
        [{"role": "user", "content": "hi"}],
        reasoning_config={"enabled": False},
    )
    assert off["extra_body"]["reasoning"] == {"enabled": False}


class TestAggregatorGlobalFallback:
    """#64187: the aggregator (MoA's acting model) resolves like any acting
    model when its slot has no reasoning_effort: per-model override
    (agent.reasoning_overrides for the slot's model) > global
    agent.reasoning_effort. Reference advisors do NOT get this fallback
    (side calls — cost containment)."""

    def test_slot_value_wins_over_global(self, monkeypatch):
        from agent import moa_loop

        monkeypatch.setattr(
            "hermes_cli.config.load_config",
            lambda: {"agent": {"reasoning_effort": "medium"}},
        )
        cfg = moa_loop._aggregator_reasoning_config({"reasoning_effort": "xhigh"})
        assert cfg == {"enabled": True, "effort": "xhigh"}

    def test_unset_slot_falls_back_to_global(self, monkeypatch):
        from agent import moa_loop

        monkeypatch.setattr(
            "hermes_cli.config.load_config",
            lambda: {"agent": {"reasoning_effort": "high"}},
        )
        cfg = moa_loop._aggregator_reasoning_config({"provider": "openrouter", "model": "m"})
        assert cfg == {"enabled": True, "effort": "high"}

    def test_unset_slot_honors_per_model_override(self, monkeypatch):
        """The aggregator's model gets its agent.reasoning_overrides entry —
        same resolution as any acting model, not just the bare global."""
        from agent import moa_loop

        monkeypatch.setattr(
            "hermes_cli.config.load_config",
            lambda: {
                "agent": {
                    "reasoning_effort": "medium",
                    "reasoning_overrides": {"claude-opus-4.8": "xhigh"},
                }
            },
        )
        cfg = moa_loop._aggregator_reasoning_config(
            {"provider": "openrouter", "model": "anthropic/claude-opus-4.8"}
        )
        assert cfg == {"enabled": True, "effort": "xhigh"}

    def test_slot_value_beats_per_model_override(self, monkeypatch):
        from agent import moa_loop

        monkeypatch.setattr(
            "hermes_cli.config.load_config",
            lambda: {
                "agent": {
                    "reasoning_effort": "medium",
                    "reasoning_overrides": {"claude-opus-4.8": "xhigh"},
                }
            },
        )
        cfg = moa_loop._aggregator_reasoning_config(
            {"model": "anthropic/claude-opus-4.8", "reasoning_effort": "low"}
        )
        assert cfg == {"enabled": True, "effort": "low"}

    def test_global_yaml_false_disables(self, monkeypatch):
        from agent import moa_loop

        monkeypatch.setattr(
            "hermes_cli.config.load_config",
            lambda: {"agent": {"reasoning_effort": False}},
        )
        cfg = moa_loop._aggregator_reasoning_config({})
        assert cfg == {"enabled": False}

    def test_no_slot_no_global_returns_none(self, monkeypatch):
        from agent import moa_loop

        monkeypatch.setattr("hermes_cli.config.load_config", lambda: {})
        assert moa_loop._aggregator_reasoning_config({}) is None

    def test_reference_slots_do_not_inherit_global(self, monkeypatch):
        """Advisors stay slot-or-default: global effort must NOT leak in."""
        from agent import moa_loop

        monkeypatch.setattr(
            "hermes_cli.config.load_config",
            lambda: {"agent": {"reasoning_effort": "xhigh"}},
        )
        assert moa_loop._slot_reasoning_config({"provider": "p", "model": "m"}) is None