mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
797c52b571
Two defects found by manual testing on the branch.
1. ORG SYNC NEVER RAN. The org pull/mirror/gating machinery was fully
implemented and unit-tested but had ZERO runtime callers —
maybe_pull_org_skills() was referenced only inside a comment, and
`hermes sync` had no org path at all. Every code path fell through to
personal sync (refs/user/<sub>/), so org skills never loaded and the
feature looked like 'everything syncs to my personal org' even with a
valid org token. The unit tests could not catch this: they invoked the
functions directly, which is exactly the gap they left open.
- cli.py session startup now calls maybe_pull_org_skills() alongside the
personal maybe_pull_skills(), fail-quiet.
- Auto-pull is gated on real org membership: resolve_org_identity()
requires an org role on the token, only issued for multi-member orgs,
so a solo account never reaches the network.
- `hermes sync pull` refreshes the org mirror too (one pull, both
surfaces) and reports what it refreshed.
- `hermes sync status` exposes org_available/org_id/org_role/org_skills
plus a plain-language summary, so a user can tell whether the org
workflow applies instead of it being invisible.
2. INTERNAL JARGON LEAKED TO USERS. Help text and errors exposed internal
milestone/spec coordinates: 'Propose a skill ... (M2)', 'Personal skill
sync (HSP/1)', 'DEV-PHASE gate closed: your token lacks
tool_gateway_admin', 'contract §4.3', and an inert message describing our
internal personal-vs-multi-member design split. All rewritten in user
language. Feature-local comments/docstrings lost their internal
coordinates (§N, M1/M2, design.md, PR numbers) while keeping the
explanatory prose. Pre-existing issue references elsewhere in the tree
were deliberately left untouched.
Tests: 4 new guards, including two that assert the CALL SITES exist so the
org pull cannot silently become dead code again (verified failing when the
wiring is removed) and one that fails if user-facing help leaks jargon.
344 passed across the sync/skills/prompt suites.
Verified against live staging with a real org token: sync status reports
org_available=true, org_role=OWNER; sync pull performs the org refresh; the
.active_org marker is written with the org id from the token.
57 lines
2.4 KiB
Python
57 lines
2.4 KiB
Python
"""``hermes sync`` subcommand parser (HSP/1 personal skill sync).
|
|
|
|
Cloned from ``hermes_cli/subcommands/cron.py`` — same injected-handler shape
|
|
(``func=cmd_sync``) so this module does not import ``main`` (cycle avoidance).
|
|
|
|
Commands:
|
|
hermes sync status -- show gate/opt-in/head state
|
|
hermes sync pull -- pull the owner's HEAD, materialize opted-in skills
|
|
hermes sync push -- push opted-in skills to the owner's HEAD
|
|
hermes sync now -- pull then push (full reconcile)
|
|
hermes sync enable <skill> -- opt a skill into sync (M1-D)
|
|
hermes sync disable <skill> -- opt a skill out of sync
|
|
hermes sync device [--name] -- show or set this device's sync label
|
|
|
|
Sync is INERT unless the resolved Nous token carries the DEV-PHASE gate claim
|
|
(tool_gateway_admin) AND a sync base URL is configured. The commands report
|
|
that state rather than failing opaquely.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Callable
|
|
|
|
|
|
def build_sync_parser(subparsers, *, cmd_sync: Callable) -> None:
|
|
"""Attach the ``sync`` subcommand (and its sub-actions) to ``subparsers``."""
|
|
sync_parser = subparsers.add_parser(
|
|
"sync",
|
|
help="Personal skill sync across your devices",
|
|
description="Sync agent-created and user-authored skills across devices.",
|
|
)
|
|
sync_sub = sync_parser.add_subparsers(dest="sync_command")
|
|
|
|
sync_sub.add_parser("status", help="Show sync gate, opt-in, and head state")
|
|
sync_sub.add_parser("pull", help="Pull the owner's HEAD and materialize opted-in skills")
|
|
sync_sub.add_parser("push", help="Push opted-in skills to the owner's HEAD")
|
|
sync_sub.add_parser("now", help="Reconcile now: pull then push")
|
|
|
|
enable = sync_sub.add_parser("enable", help="Opt a skill into sync")
|
|
enable.add_argument("skill", help="Skill name (frontmatter name / directory name)")
|
|
|
|
disable = sync_sub.add_parser("disable", help="Opt a skill out of sync")
|
|
disable.add_argument("skill", help="Skill name (frontmatter name / directory name)")
|
|
|
|
device = sync_sub.add_parser(
|
|
"device",
|
|
help="Show or set this device's sync label (shown in the sync console)",
|
|
)
|
|
device.add_argument(
|
|
"--name",
|
|
dest="device_name",
|
|
default=None,
|
|
help="Set a human-friendly label for this device (e.g. \"Ben's Laptop\"). "
|
|
"Omit to print the current label.",
|
|
)
|
|
|
|
sync_parser.set_defaults(func=cmd_sync)
|