mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
031f9c9edc
xAI's grok-imagine-image API returns ephemeral imgen.x.ai/xai-tmp-* URLs that 404 within minutes — long before downstream consumers (Telegram send_photo, browser preview, multi-tier delivery fallback) get a chance to fetch them. The xAI image_gen provider was passing those URLs through unchanged on the elif url: branch; b64 responses were already cached locally via save_b64_image. Result: every image_generate call on a Telegram-routed xai-oauth profile delivered no image, falling through to text-only. Adds agent.image_gen_provider.save_url_image() — a sibling helper to save_b64_image that downloads URL bytes to $HERMES_HOME/cache/images/. Content-type-aware extension inference with URL-suffix fallback; oversize cap (25MB default) with partial-write cleanup; empty-body refusal. Mirrors the audio_cache pattern used by text_to_speech. Wires save_url_image into both the xAI and OpenAI providers' URL branches. When the download fails (network blip, 404 in-flight) we log a warning and fall back to the bare URL rather than turning the tool call into a hard error — the gateway's existing URL-send fallback then gets a chance to surface the original error legibly. Test plan: - tests/agent/test_save_url_image.py — 8 direct tests against a real in-process HTTP server: bytes round-trip, content-type → extension, URL-suffix fallback, default-to-png, 404 propagation, empty-body refusal, oversize cap + cleanup, filename uniqueness. - tests/plugins/image_gen/test_xai_provider.py — flip test_successful_url_response (was asserting the bug), add test_url_response_falls_back_to_bare_url_when_download_fails. - tests/plugins/image_gen/test_openai_provider.py — symmetric pair. 160/160 in the broader image_gen test surface.
337 lines
13 KiB
Python
337 lines
13 KiB
Python
#!/usr/bin/env python3
|
|
"""Tests for xAI image generation provider."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Fixtures
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _fake_api_key(monkeypatch):
|
|
"""Ensure XAI_API_KEY is set for all tests."""
|
|
monkeypatch.setenv("XAI_API_KEY", "test-key-12345")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Provider class tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestXAIImageGenProvider:
|
|
def test_name(self):
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
provider = XAIImageGenProvider()
|
|
assert provider.name == "xai"
|
|
|
|
def test_display_name(self):
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
provider = XAIImageGenProvider()
|
|
assert provider.display_name == "xAI (Grok)"
|
|
|
|
def test_is_available_with_key(self, monkeypatch):
|
|
monkeypatch.setenv("XAI_API_KEY", "sk-xxx")
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
provider = XAIImageGenProvider()
|
|
assert provider.is_available() is True
|
|
|
|
def test_is_available_without_key(self, monkeypatch):
|
|
monkeypatch.delenv("XAI_API_KEY", raising=False)
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
provider = XAIImageGenProvider()
|
|
assert provider.is_available() is False
|
|
|
|
def test_list_models(self):
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
provider = XAIImageGenProvider()
|
|
models = provider.list_models()
|
|
assert len(models) >= 1
|
|
assert models[0]["id"] == "grok-imagine-image"
|
|
|
|
def test_default_model(self):
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
provider = XAIImageGenProvider()
|
|
assert provider.default_model() == "grok-imagine-image"
|
|
|
|
def test_get_setup_schema(self):
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
provider = XAIImageGenProvider()
|
|
schema = provider.get_setup_schema()
|
|
assert schema["name"] == "xAI Grok Imagine (image)"
|
|
assert schema["badge"] == "paid"
|
|
# Auth resolution is delegated to the shared "xai_grok" post_setup
|
|
# hook so the picker doesn't blindly prompt for XAI_API_KEY when the
|
|
# user is already signed in via xAI Grok OAuth.
|
|
assert schema["env_vars"] == []
|
|
assert schema["post_setup"] == "xai_grok"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Config tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestConfig:
|
|
def test_default_model(self):
|
|
from plugins.image_gen.xai import _resolve_model
|
|
|
|
model_id, meta = _resolve_model()
|
|
assert model_id == "grok-imagine-image"
|
|
|
|
def test_default_resolution(self):
|
|
from plugins.image_gen.xai import _resolve_resolution
|
|
|
|
assert _resolve_resolution() == "1k"
|
|
|
|
def test_custom_model(self, monkeypatch):
|
|
monkeypatch.setenv("XAI_IMAGE_MODEL", "grok-imagine-image")
|
|
from plugins.image_gen.xai import _resolve_model
|
|
|
|
model_id, _ = _resolve_model()
|
|
assert model_id == "grok-imagine-image"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Generate tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestGenerate:
|
|
def test_missing_api_key(self, monkeypatch):
|
|
monkeypatch.delenv("XAI_API_KEY", raising=False)
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
provider = XAIImageGenProvider()
|
|
result = provider.generate(prompt="test")
|
|
assert result["success"] is False
|
|
assert "XAI_API_KEY" in result["error"]
|
|
|
|
def test_successful_generation(self):
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
mock_resp = MagicMock()
|
|
mock_resp.status_code = 200
|
|
mock_resp.raise_for_status = MagicMock()
|
|
mock_resp.json.return_value = {
|
|
"data": [{"b64_json": "dGVzdC1pbWFnZS1kYXRh"}], # base64 "test-image-data"
|
|
}
|
|
|
|
with patch("plugins.image_gen.xai.requests.post", return_value=mock_resp):
|
|
with patch("plugins.image_gen.xai.save_b64_image", return_value="/tmp/test.png"):
|
|
provider = XAIImageGenProvider()
|
|
result = provider.generate(prompt="A cat playing piano")
|
|
|
|
assert result["success"] is True
|
|
assert result["image"] == "/tmp/test.png"
|
|
assert result["provider"] == "xai"
|
|
assert result["model"] == "grok-imagine-image"
|
|
|
|
def test_successful_url_response(self):
|
|
"""xAI URL response is cached locally — #26942 contract.
|
|
|
|
Pre-fix this asserted ``result["image"] == "<the bare URL>"``, which
|
|
was exactly the bug: xAI's ``imgen.x.ai/xai-tmp-*`` URLs expire fast
|
|
and the gateway 404'd by ``send_photo`` time. Post-fix the URL
|
|
bytes are downloaded at tool-completion and the result carries an
|
|
absolute filesystem path the gateway can upload from.
|
|
"""
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
mock_resp = MagicMock()
|
|
mock_resp.status_code = 200
|
|
mock_resp.raise_for_status = MagicMock()
|
|
mock_resp.json.return_value = {
|
|
"data": [{"url": "https://imgen.x.ai/xai-tmp-imgen-test.jpeg"}],
|
|
}
|
|
|
|
with patch("plugins.image_gen.xai.requests.post", return_value=mock_resp), \
|
|
patch(
|
|
"plugins.image_gen.xai.save_url_image",
|
|
return_value=Path("/tmp/xai_grok-imagine-image_20260524_000000_deadbeef.jpg"),
|
|
) as mock_save_url:
|
|
provider = XAIImageGenProvider()
|
|
result = provider.generate(prompt="A cat playing piano")
|
|
|
|
assert result["success"] is True
|
|
assert result["image"].startswith("/"), (
|
|
f"URL response must be cached to an absolute path, got {result['image']!r}"
|
|
)
|
|
assert "imgen.x.ai" not in result["image"], (
|
|
"ephemeral xAI URL must not leak into result.image — caller will 404"
|
|
)
|
|
# The downloader should have been called exactly once with the URL
|
|
# and an xai-prefixed cache filename.
|
|
mock_save_url.assert_called_once()
|
|
call_args, call_kwargs = mock_save_url.call_args
|
|
assert call_args[0] == "https://imgen.x.ai/xai-tmp-imgen-test.jpeg"
|
|
assert call_kwargs.get("prefix", "").startswith("xai_")
|
|
|
|
def test_url_response_falls_back_to_bare_url_when_download_fails(self):
|
|
"""If caching the URL fails (network blip, 404 in-flight), the
|
|
provider must NOT hard-error — fall through to returning the bare
|
|
URL so the agent surface at least sees *something*. The gateway's
|
|
existing URL-send fallback then has a chance to succeed; if it
|
|
too 404s, the user gets the original (now legible) error rather
|
|
than an opaque "image generation failed" tool result.
|
|
"""
|
|
import requests as req_lib
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
mock_resp = MagicMock()
|
|
mock_resp.status_code = 200
|
|
mock_resp.raise_for_status = MagicMock()
|
|
mock_resp.json.return_value = {
|
|
"data": [{"url": "https://imgen.x.ai/xai-tmp-imgen-already-404.jpeg"}],
|
|
}
|
|
|
|
with patch("plugins.image_gen.xai.requests.post", return_value=mock_resp), \
|
|
patch(
|
|
"plugins.image_gen.xai.save_url_image",
|
|
side_effect=req_lib.HTTPError("404 from CDN"),
|
|
):
|
|
provider = XAIImageGenProvider()
|
|
result = provider.generate(prompt="A cat playing piano")
|
|
|
|
assert result["success"] is True, (
|
|
"Cache failure must not turn into a tool error — gateway gets a chance to retry"
|
|
)
|
|
assert result["image"] == "https://imgen.x.ai/xai-tmp-imgen-already-404.jpeg"
|
|
|
|
def test_api_error(self):
|
|
import requests as req_lib
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
mock_resp = MagicMock()
|
|
mock_resp.status_code = 401
|
|
mock_resp.text = "Unauthorized"
|
|
mock_resp.json.return_value = {"error": {"message": "Invalid API key"}}
|
|
mock_resp.raise_for_status.side_effect = req_lib.HTTPError(response=mock_resp)
|
|
|
|
with patch("plugins.image_gen.xai.requests.post", return_value=mock_resp):
|
|
provider = XAIImageGenProvider()
|
|
result = provider.generate(prompt="test")
|
|
|
|
assert result["success"] is False
|
|
assert result["error_type"] == "api_error"
|
|
|
|
def test_api_error_preserves_real_response_status(self):
|
|
import requests as req_lib
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
response = req_lib.Response()
|
|
response.status_code = 401
|
|
response._content = json.dumps({"error": {"message": "Invalid API key"}}).encode()
|
|
response.headers["Content-Type"] = "application/json"
|
|
|
|
response.raise_for_status = MagicMock(
|
|
side_effect=req_lib.HTTPError(response=response)
|
|
)
|
|
|
|
with patch("plugins.image_gen.xai.requests.post", return_value=response):
|
|
provider = XAIImageGenProvider()
|
|
result = provider.generate(prompt="test")
|
|
|
|
assert result["success"] is False
|
|
assert result["error_type"] == "api_error"
|
|
assert "xAI image generation failed (401): Invalid API key" in result["error"]
|
|
|
|
def test_timeout(self):
|
|
import requests as req_lib
|
|
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
with patch("plugins.image_gen.xai.requests.post", side_effect=req_lib.Timeout()):
|
|
provider = XAIImageGenProvider()
|
|
result = provider.generate(prompt="test")
|
|
|
|
assert result["success"] is False
|
|
assert result["error_type"] == "timeout"
|
|
|
|
def test_empty_response(self):
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
mock_resp = MagicMock()
|
|
mock_resp.status_code = 200
|
|
mock_resp.raise_for_status = MagicMock()
|
|
mock_resp.json.return_value = {"data": []}
|
|
|
|
with patch("plugins.image_gen.xai.requests.post", return_value=mock_resp):
|
|
provider = XAIImageGenProvider()
|
|
result = provider.generate(prompt="test")
|
|
|
|
assert result["success"] is False
|
|
assert result["error_type"] == "empty_response"
|
|
|
|
def test_auth_header(self):
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
mock_resp = MagicMock()
|
|
mock_resp.status_code = 200
|
|
mock_resp.raise_for_status = MagicMock()
|
|
mock_resp.json.return_value = {
|
|
"data": [{"url": "https://xai.image/test.png"}],
|
|
}
|
|
|
|
with patch("plugins.image_gen.xai.requests.post", return_value=mock_resp) as mock_post:
|
|
provider = XAIImageGenProvider()
|
|
provider.generate(prompt="test")
|
|
|
|
call_args = mock_post.call_args
|
|
headers = call_args.kwargs.get("headers") or call_args[1].get("headers")
|
|
assert "Bearer test-key-12345" in headers["Authorization"]
|
|
assert "Hermes-Agent" in headers["User-Agent"]
|
|
|
|
def test_payload_resolution_is_literal_1k_or_2k(self):
|
|
"""Regression: xAI API rejects numeric resolutions ("1024"/"2048") with 422.
|
|
|
|
The endpoint expects the literal strings "1k" or "2k". Ensure the wire
|
|
payload carries that literal — not a numeric mapping. See PR #18678.
|
|
"""
|
|
from plugins.image_gen.xai import XAIImageGenProvider
|
|
|
|
mock_resp = MagicMock()
|
|
mock_resp.status_code = 200
|
|
mock_resp.raise_for_status = MagicMock()
|
|
mock_resp.json.return_value = {"data": [{"url": "https://xai.image/test.png"}]}
|
|
|
|
with patch("plugins.image_gen.xai.requests.post", return_value=mock_resp) as mock_post:
|
|
provider = XAIImageGenProvider()
|
|
provider.generate(prompt="test")
|
|
|
|
payload = mock_post.call_args.kwargs.get("json") or mock_post.call_args[1].get("json")
|
|
assert payload["resolution"] in {"1k", "2k"}, (
|
|
f"resolution must be the literal '1k' or '2k', got {payload['resolution']!r}"
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Registration test
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestRegistration:
|
|
def test_register(self):
|
|
from plugins.image_gen.xai import XAIImageGenProvider, register
|
|
|
|
mock_ctx = MagicMock()
|
|
register(mock_ctx)
|
|
mock_ctx.register_image_gen_provider.assert_called_once()
|
|
provider = mock_ctx.register_image_gen_provider.call_args[0][0]
|
|
assert isinstance(provider, XAIImageGenProvider)
|
|
assert provider.name == "xai"
|