mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
89 lines
3 KiB
Python
89 lines
3 KiB
Python
"""Tests for the get_nous_auth_status() process-level cache.
|
||
|
||
The cache avoids re-validating Nous credentials on every menu paint —
|
||
`hermes tools` → "All Platforms" used to fire ~31 OAuth refresh POSTs
|
||
against portal.nousresearch.com during one render. The cache is keyed
|
||
on auth.json path + mtime so profile switches stay isolated while
|
||
login/logout flows invalidate naturally; tests and other writers can
|
||
also call invalidate_nous_auth_status_cache().
|
||
"""
|
||
|
||
from __future__ import annotations
|
||
|
||
import json
|
||
import os
|
||
from unittest.mock import patch
|
||
|
||
|
||
def _seed_auth_file(tmp_path):
|
||
"""Drop a placeholder auth.json into the test HERMES_HOME.
|
||
|
||
The exact content doesn't matter for cache-key purposes — only that
|
||
the file exists and we can mutate it to bump mtime.
|
||
"""
|
||
auth = tmp_path / "auth.json"
|
||
auth.write_text(json.dumps({"providers": {}}), encoding="utf-8")
|
||
return auth
|
||
|
||
|
||
def test_get_nous_auth_status_caches_consecutive_calls(tmp_path, monkeypatch):
|
||
"""A second call within the TTL skips re-computing the snapshot."""
|
||
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
||
_seed_auth_file(tmp_path)
|
||
|
||
from hermes_cli import auth as auth_mod
|
||
|
||
auth_mod.invalidate_nous_auth_status_cache()
|
||
|
||
call_count = {"n": 0}
|
||
|
||
def fake_compute():
|
||
call_count["n"] += 1
|
||
return {"logged_in": False, "source": "auth_store", "call": call_count["n"]}
|
||
|
||
with patch.object(auth_mod, "_compute_nous_auth_status", side_effect=fake_compute):
|
||
first = auth_mod.get_nous_auth_status()
|
||
second = auth_mod.get_nous_auth_status()
|
||
third = auth_mod.get_nous_auth_status()
|
||
|
||
assert call_count["n"] == 1, (
|
||
f"_compute_nous_auth_status was called {call_count['n']}× — "
|
||
"cache is not deduplicating within TTL."
|
||
)
|
||
# Each call returns a copy so callers can't mutate the cached dict.
|
||
assert first == second == third
|
||
first["mutated"] = True
|
||
assert "mutated" not in auth_mod.get_nous_auth_status()
|
||
|
||
auth_mod.invalidate_nous_auth_status_cache()
|
||
|
||
|
||
def test_get_nous_auth_status_caches_failure_path(tmp_path, monkeypatch):
|
||
"""Logged-out snapshots are cached too — that's where the cost was.
|
||
|
||
Teknium's case: ~31 cache misses per `hermes tools` "All Platforms"
|
||
menu paint, all returning logged_in=False after a failed refresh POST.
|
||
The whole point of the cache is to memoise that failure path too.
|
||
"""
|
||
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
||
_seed_auth_file(tmp_path)
|
||
|
||
from hermes_cli import auth as auth_mod
|
||
|
||
auth_mod.invalidate_nous_auth_status_cache()
|
||
|
||
call_count = {"n": 0}
|
||
|
||
def fake_compute():
|
||
call_count["n"] += 1
|
||
return {"logged_in": False, "source": "auth_store", "error": "refresh failed"}
|
||
|
||
with patch.object(auth_mod, "_compute_nous_auth_status", side_effect=fake_compute):
|
||
for _ in range(10):
|
||
auth_mod.get_nous_auth_status()
|
||
|
||
assert call_count["n"] == 1, (
|
||
f"Logged-out snapshots must cache; got {call_count['n']} computes for 10 calls."
|
||
)
|
||
|
||
auth_mod.invalidate_nous_auth_status_cache()
|