mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
78 lines
2.6 KiB
Python
78 lines
2.6 KiB
Python
"""Tests for session-scoped-by-default model switching.
|
|
|
|
Covers:
|
|
- ``parse_model_flags`` recognises ``--session`` (and keeps ``--global``).
|
|
- ``resolve_persist_behavior`` applies the config-gated default and the
|
|
``--session`` / ``--global`` overrides.
|
|
- The default (no flags) is session-only, which is the user-facing fix: a
|
|
plain ``/model <name>`` affects only the current session unless the user
|
|
passes ``--global`` or sets ``model.persist_switch_by_default: true``.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from hermes_cli.model_switch import parse_model_flags, resolve_persist_behavior
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# parse_model_flags
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestParseModelFlagsSession:
|
|
def test_no_flags(self):
|
|
assert parse_model_flags("sonnet") == ("sonnet", "", False, False, False)
|
|
|
|
|
|
def test_unicode_dash_session_normalized(self):
|
|
# Telegram/iOS auto-converts -- to en/em dashes.
|
|
assert parse_model_flags("sonnet \u2013session") == (
|
|
"sonnet",
|
|
"",
|
|
False,
|
|
False,
|
|
True,
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# resolve_persist_behavior
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestResolvePersistBehavior:
|
|
def test_session_flag_always_session_only(self):
|
|
# --session opts out even if the config default is True.
|
|
with _config({"model": {"persist_switch_by_default": True}}):
|
|
assert resolve_persist_behavior(False, True) is False
|
|
|
|
|
|
def test_no_provider_uses_config_default(self):
|
|
# No --provider → respects config default (True).
|
|
with _config({"model": {"persist_switch_by_default": True}}):
|
|
assert resolve_persist_behavior(False, False, explicit_provider="") is True
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# helper
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class _config:
|
|
"""Context manager that patches ``load_config`` to return a fixed dict."""
|
|
|
|
def __init__(self, cfg: dict):
|
|
self.cfg = cfg
|
|
|
|
def __enter__(self):
|
|
self._patch = patch(
|
|
"hermes_cli.config.load_config",
|
|
return_value=self.cfg,
|
|
)
|
|
# resolve_persist_behavior imports load_config lazily inside the
|
|
# function, so patching the source module is sufficient.
|
|
self._patch.start()
|
|
return self
|
|
|
|
def __exit__(self, *exc):
|
|
self._patch.stop()
|