mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
73 lines
2 KiB
Python
73 lines
2 KiB
Python
"""Pool-only credentials must be visible to interactive model setup flows."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import patch
|
|
|
|
from hermes_cli.auth import PROVIDER_REGISTRY
|
|
from hermes_cli.model_setup_flows import _existing_api_key_for_model_flow
|
|
|
|
|
|
class _PoolEntry:
|
|
access_token = "pool-secret"
|
|
runtime_api_key = ""
|
|
|
|
|
|
class _AvailablePool:
|
|
def has_credentials(self) -> bool:
|
|
return True
|
|
|
|
def peek(self):
|
|
return _PoolEntry()
|
|
|
|
|
|
class _ExhaustedPool:
|
|
def has_credentials(self) -> bool:
|
|
return True
|
|
|
|
def peek(self):
|
|
return None
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_generic_api_key_flow_passes_pool_key_to_existing_key_prompt(monkeypatch):
|
|
from hermes_cli.model_setup_flows import _model_flow_api_key_provider
|
|
|
|
monkeypatch.delenv("DEEPSEEK_API_KEY", raising=False)
|
|
captured: dict[str, str] = {}
|
|
|
|
def capture_prompt(_pconfig, existing_key, **_kwargs):
|
|
captured["existing_key"] = existing_key
|
|
return existing_key, True
|
|
|
|
with (
|
|
patch("hermes_cli.config.get_env_value", return_value=""),
|
|
patch("agent.credential_pool.load_pool", return_value=_AvailablePool()),
|
|
patch("hermes_cli.main._prompt_api_key", side_effect=capture_prompt),
|
|
):
|
|
_model_flow_api_key_provider({}, "deepseek")
|
|
|
|
assert captured["existing_key"] == "pool-secret"
|
|
|
|
|
|
|
|
|
|
def test_bedrock_flow_sees_pool_key_when_no_env(monkeypatch, capsys):
|
|
"""Bedrock API-key mode must also see pool-backed credentials."""
|
|
from hermes_cli.model_setup_flows import _model_flow_bedrock_api_key
|
|
|
|
monkeypatch.delenv("AWS_BEARER_TOKEN_BEDROCK", raising=False)
|
|
|
|
with (
|
|
patch("hermes_cli.config.get_env_value", return_value=""),
|
|
patch("agent.credential_pool.load_pool", return_value=_AvailablePool()),
|
|
patch("builtins.input", return_value="k"),
|
|
):
|
|
_model_flow_bedrock_api_key({}, "us-east-1")
|
|
|
|
out = capsys.readouterr().out
|
|
# The flow should show the pool-backed key, not prompt for a new one
|
|
assert "pool-secret" in out[:200] or "pool-sec" in out[:200]
|