mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-21 10:22:18 +00:00
016bce1a09
* fix(desktop): recover stranded session windows when resume fails
Opening a session in a new window (or any routed resume) could latch the
thread loader on "session" forever — the reported "stays stuck loading,
even after a nap" bug. Two compounding causes:
1. use-session-actions.resumeSession's catch ran the REST transcript
fallback OUTSIDE its own try. When session.resume rejected AND the
fallback also threw (the common case on a wedged/unreachable backend),
the throw skipped setMessages and left activeSessionId null with an
empty transcript — exactly the state the loader gates on
(messagesEmpty && !activeSessionId), with no terminal/error state.
2. use-route-resume's self-heal could never re-fire: resumeSession sets
selectedStoredSessionIdRef synchronously at entry (before failing), so
stuckOnRoutedSession stays false, and on an already-open idle window
neither pathnameChanged nor gatewayBecameOpen fire again. The window
never retried — naps, focus, nothing recovered it.
Fix:
- Wrap the REST fallback in its own try so a fallback failure can't strand
the loader.
- Add $resumeFailedSessionId: armed on terminal resume failure, cleared at
the next resume's entry (and left clear on success).
- use-route-resume gains a bounded backoff auto-retry (4 attempts, 1s→8s)
that re-resumes while the routed session matches the failure flag, with a
fire-time liveness recheck so a recovered session isn't double-resumed.
Regression tests cover: fallback-wrap arming the flag without throwing,
flag cleared on success, retry fires on backoff, no retry for a
non-routed/recovered session, and the retry cap.
* feat(desktop): show error + manual Retry when resume retries exhaust
When a stranded session window's bounded auto-retry gives up (gateway
resume RPC + REST fallback fail through all MAX_RESUME_RETRIES attempts),
the loader latched forever. Add a $resumeExhaustedSessionId atom armed at
the give-up point so the chat view swaps the perpetual spinner for an
explicit error state + manual Retry button. Retry / reconnect / reselect
clears the latch and resets the auto-retry counter for a fresh cycle; a
route-change away from the stranded session also clears it.
Distinct from $resumeFailedSessionId (armed during the backoff window) so
the error UI only appears once auto-recovery has actually given up, not
mid-retry. Adds i18n strings across en/ja/zh/zh-hant and 3 tests covering
latch-arms-on-exhaustion, stays-clear-while-retries-remain, and
clears-on-route-change.
* fix(desktop): address review on stranded-resume recovery layer
Follow-up to review on #47655 (PR head
|
||
|---|---|---|
| .. | ||
| activity.ts | ||
| boot.ts | ||
| clarify.test.ts | ||
| clarify.ts | ||
| command-palette.ts | ||
| compaction.test.ts | ||
| compaction.ts | ||
| completion-sound.ts | ||
| composer-input-history.test.ts | ||
| composer-input-history.ts | ||
| composer-queue.test.ts | ||
| composer-queue.ts | ||
| composer-status.test.ts | ||
| composer-status.ts | ||
| composer.test.ts | ||
| composer.ts | ||
| cron.ts | ||
| gateway.ts | ||
| haptics.ts | ||
| keybinds.ts | ||
| layout.ts | ||
| model-presets.test.ts | ||
| model-presets.ts | ||
| model-visibility.test.ts | ||
| model-visibility.ts | ||
| native-notifications.test.ts | ||
| native-notifications.ts | ||
| notifications.ts | ||
| onboarding.test.ts | ||
| onboarding.ts | ||
| panes.test.ts | ||
| panes.ts | ||
| preview.test.ts | ||
| preview.ts | ||
| profile.test.ts | ||
| profile.ts | ||
| prompts.test.ts | ||
| prompts.ts | ||
| session-switcher.test.ts | ||
| session-switcher.ts | ||
| session-sync.ts | ||
| session.test.ts | ||
| session.ts | ||
| subagents.test.ts | ||
| subagents.ts | ||
| thread-scroll.ts | ||
| todos.test.ts | ||
| todos.ts | ||
| tool-diffs.ts | ||
| tool-dismiss.ts | ||
| tool-view.ts | ||
| translucency.ts | ||
| updates.test.ts | ||
| updates.ts | ||
| voice-playback.ts | ||
| windows.test.ts | ||
| windows.ts | ||