mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
63 lines
2.1 KiB
Python
63 lines
2.1 KiB
Python
"""Tests for _parse_env_var and _get_env_config env-var validation."""
|
|
|
|
import importlib
|
|
import json
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
import sys
|
|
import tools.terminal_tool # noqa: F401 -- ensure module is loaded
|
|
_tt_mod = sys.modules["tools.terminal_tool"]
|
|
from tools.terminal_tool import _parse_env_var
|
|
|
|
|
|
class TestParseEnvVar:
|
|
"""Unit tests for _parse_env_var."""
|
|
|
|
# -- valid values work normally --
|
|
|
|
def test_valid_int(self):
|
|
with patch.dict("os.environ", {"TERMINAL_TIMEOUT": "300"}):
|
|
assert _parse_env_var("TERMINAL_TIMEOUT", "180") == 300
|
|
|
|
|
|
def test_get_env_config_parses_docker_forward_env_json(self):
|
|
with patch.dict("os.environ", {
|
|
"TERMINAL_ENV": "docker",
|
|
"TERMINAL_DOCKER_FORWARD_ENV": '["GITHUB_TOKEN", "NPM_TOKEN"]',
|
|
}, clear=False):
|
|
config = _tt_mod._get_env_config()
|
|
assert config["docker_forward_env"] == ["GITHUB_TOKEN", "NPM_TOKEN"]
|
|
|
|
|
|
# -- invalid int raises ValueError with env var name --
|
|
|
|
|
|
# -- invalid JSON raises ValueError with env var name --
|
|
|
|
|
|
def test_invalid_json_includes_type_label(self):
|
|
with patch.dict("os.environ", {"TERMINAL_DOCKER_VOLUMES": "not json"}):
|
|
with pytest.raises(ValueError, match="valid JSON"):
|
|
_parse_env_var("TERMINAL_DOCKER_VOLUMES", "[]", json.loads, "valid JSON")
|
|
|
|
|
|
class TestImportTimeEnvParsing:
|
|
"""Module-level env parsing should never make terminal_tool unimportable."""
|
|
|
|
def test_invalid_foreground_timeout_falls_back_to_default(self):
|
|
try:
|
|
with patch.dict("os.environ", {"TERMINAL_MAX_FOREGROUND_TIMEOUT": "5m"}, clear=False):
|
|
mod = importlib.reload(_tt_mod)
|
|
assert mod.FOREGROUND_MAX_TIMEOUT == 600
|
|
finally:
|
|
importlib.reload(_tt_mod)
|
|
|
|
def test_invalid_disk_warning_threshold_falls_back_to_default(self):
|
|
try:
|
|
with patch.dict("os.environ", {"TERMINAL_DISK_WARNING_GB": "huge"}, clear=False):
|
|
mod = importlib.reload(_tt_mod)
|
|
assert mod.DISK_USAGE_WARNING_THRESHOLD_GB == 500.0
|
|
finally:
|
|
importlib.reload(_tt_mod)
|