mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-08 03:01:47 +00:00
e795b7e3ab
When the parent agent uses a composite toolset like hermes-cli, calling delegate_task with individual toolsets (e.g. web, terminal) resulted in zero tools because the name-based intersection failed: 'web' != 'hermes-cli'. Add _expand_parent_toolsets() which collects all tool names from parent toolsets, then recognises any individual toolset whose tools are a subset of the parent's available tools. This allows delegate_task(toolsets=['web']) to work correctly when the parent has hermes-cli enabled. Fixes #19447
46 lines
1.8 KiB
Python
46 lines
1.8 KiB
Python
"""Tests for composite toolset expansion in delegate_task intersection."""
|
|
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
from tools.delegate_tool import _expand_parent_toolsets
|
|
|
|
|
|
class TestExpandParentToolsets(unittest.TestCase):
|
|
"""Verify _expand_parent_toolsets recognises individual toolsets within composites."""
|
|
|
|
def test_composite_hermes_cli_expands_web(self):
|
|
"""hermes-cli includes web_search/web_extract → 'web' should be in expansion."""
|
|
expanded = _expand_parent_toolsets({"hermes-cli"})
|
|
self.assertIn("web", expanded)
|
|
self.assertIn("terminal", expanded)
|
|
self.assertIn("browser", expanded)
|
|
# Original composite is preserved
|
|
self.assertIn("hermes-cli", expanded)
|
|
|
|
def test_individual_toolset_unchanged(self):
|
|
"""When parent already uses individual toolsets, expansion keeps them."""
|
|
expanded = _expand_parent_toolsets({"web", "terminal"})
|
|
self.assertIn("web", expanded)
|
|
self.assertIn("terminal", expanded)
|
|
|
|
def test_empty_parent_toolsets(self):
|
|
expanded = _expand_parent_toolsets(set())
|
|
self.assertEqual(expanded, set())
|
|
|
|
def test_unknown_toolset_passthrough(self):
|
|
"""Unknown toolset names pass through without error."""
|
|
expanded = _expand_parent_toolsets({"nonexistent-toolset-xyz"})
|
|
self.assertIn("nonexistent-toolset-xyz", expanded)
|
|
|
|
def test_intersection_with_expanded_composite(self):
|
|
"""End-to-end: requesting ['web'] from parent with ['hermes-cli'] yields ['web']."""
|
|
parent_toolsets = {"hermes-cli"}
|
|
expanded = _expand_parent_toolsets(parent_toolsets)
|
|
toolsets = ["web"]
|
|
child_toolsets = [t for t in toolsets if t in expanded]
|
|
self.assertEqual(child_toolsets, ["web"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|