mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
100 lines
3.6 KiB
Python
100 lines
3.6 KiB
Python
"""Tests for tui_gateway/entry.py sys.path hardening (issue #15989).
|
|
|
|
When the TUI backend is spawned by Node.js, the Python interpreter may have
|
|
'' or '.' at the front of sys.path, allowing a local utils/ directory in CWD
|
|
to shadow the installed utils module. entry.py must sanitize sys.path before
|
|
any non-stdlib import is resolved.
|
|
"""
|
|
|
|
import os
|
|
import sys
|
|
from unittest.mock import patch
|
|
|
|
|
|
def _reload_entry_with_env(env_overrides: dict) -> None:
|
|
"""Re-execute entry.py's module-level path setup under a controlled env."""
|
|
# We only want to exercise the sys.path fixup block, not the signal/import
|
|
# machinery that follows. We do this by running the fixup code verbatim in
|
|
# a fresh copy of sys.path rather than importing the real module (which
|
|
# would trigger tui_gateway.server imports requiring heavy mocks).
|
|
original_path = sys.path[:]
|
|
original_env = {k: os.environ.get(k) for k in env_overrides}
|
|
try:
|
|
with patch.dict(os.environ, env_overrides, clear=False):
|
|
_src_root = os.environ.get("HERMES_PYTHON_SRC_ROOT", "")
|
|
if _src_root and _src_root not in sys.path:
|
|
sys.path.insert(0, _src_root)
|
|
sys.path = [p for p in sys.path if p not in {"", "."}]
|
|
return sys.path[:]
|
|
finally:
|
|
sys.path = original_path
|
|
for k, v in original_env.items():
|
|
if v is None:
|
|
os.environ.pop(k, None)
|
|
else:
|
|
os.environ[k] = v
|
|
|
|
|
|
def test_empty_string_and_dot_removed_from_sys_path():
|
|
original = sys.path[:]
|
|
try:
|
|
sys.path.insert(0, "")
|
|
sys.path.insert(0, ".")
|
|
assert "" in sys.path
|
|
assert "." in sys.path
|
|
|
|
# Run the entry.py fixup logic directly
|
|
sys.path = [p for p in sys.path if p not in {"", "."}]
|
|
|
|
assert "" not in sys.path
|
|
assert "." not in sys.path
|
|
finally:
|
|
sys.path = original
|
|
|
|
|
|
def test_hermes_src_root_inserted_at_front():
|
|
original = sys.path[:]
|
|
try:
|
|
fake_root = "/fake/hermes/src"
|
|
with patch.dict(os.environ, {"HERMES_PYTHON_SRC_ROOT": fake_root}):
|
|
_src_root = os.environ.get("HERMES_PYTHON_SRC_ROOT", "")
|
|
if _src_root and _src_root not in sys.path:
|
|
sys.path.insert(0, _src_root)
|
|
sys.path = [p for p in sys.path if p not in {"", "."}]
|
|
|
|
assert sys.path[0] == fake_root
|
|
finally:
|
|
sys.path = original
|
|
|
|
|
|
def test_src_root_not_duplicated_if_already_present():
|
|
original = sys.path[:]
|
|
try:
|
|
fake_root = "/already/present"
|
|
sys.path.insert(0, fake_root)
|
|
count_before = sys.path.count(fake_root)
|
|
|
|
with patch.dict(os.environ, {"HERMES_PYTHON_SRC_ROOT": fake_root}):
|
|
_src_root = os.environ.get("HERMES_PYTHON_SRC_ROOT", "")
|
|
if _src_root and _src_root not in sys.path:
|
|
sys.path.insert(0, _src_root)
|
|
sys.path = [p for p in sys.path if p not in {"", "."}]
|
|
|
|
assert sys.path.count(fake_root) == count_before
|
|
finally:
|
|
sys.path = original
|
|
|
|
|
|
def test_no_src_root_env_does_not_crash():
|
|
original = sys.path[:]
|
|
try:
|
|
env = {k: v for k, v in os.environ.items() if k != "HERMES_PYTHON_SRC_ROOT"}
|
|
with patch.dict(os.environ, {}, clear=True):
|
|
os.environ.update(env)
|
|
_src_root = os.environ.get("HERMES_PYTHON_SRC_ROOT", "")
|
|
if _src_root and _src_root not in sys.path:
|
|
sys.path.insert(0, _src_root)
|
|
sys.path = [p for p in sys.path if p not in {"", "."}]
|
|
# No exception raised
|
|
finally:
|
|
sys.path = original
|