mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-31 06:51:29 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
95 lines
2.7 KiB
Python
95 lines
2.7 KiB
Python
"""Tests for tools/skill_provenance.py — write-origin ContextVar."""
|
|
|
|
import contextvars
|
|
|
|
|
|
|
|
|
|
|
|
def test_set_and_get_origin():
|
|
from tools.skill_provenance import (
|
|
set_current_write_origin,
|
|
reset_current_write_origin,
|
|
get_current_write_origin,
|
|
)
|
|
token = set_current_write_origin("background_review")
|
|
try:
|
|
assert get_current_write_origin() == "background_review"
|
|
finally:
|
|
reset_current_write_origin(token)
|
|
|
|
|
|
def test_reset_restores_prior_origin():
|
|
from tools.skill_provenance import (
|
|
set_current_write_origin,
|
|
reset_current_write_origin,
|
|
get_current_write_origin,
|
|
)
|
|
outer = set_current_write_origin("assistant_tool")
|
|
try:
|
|
inner = set_current_write_origin("background_review")
|
|
try:
|
|
assert get_current_write_origin() == "background_review"
|
|
finally:
|
|
reset_current_write_origin(inner)
|
|
assert get_current_write_origin() == "assistant_tool"
|
|
finally:
|
|
reset_current_write_origin(outer)
|
|
|
|
|
|
def test_is_background_review_truthy_only_for_review():
|
|
from tools.skill_provenance import (
|
|
set_current_write_origin,
|
|
reset_current_write_origin,
|
|
is_background_review,
|
|
BACKGROUND_REVIEW,
|
|
)
|
|
for origin, expected in (
|
|
("foreground", False),
|
|
("assistant_tool", False),
|
|
("random_other_value", False),
|
|
(BACKGROUND_REVIEW, True),
|
|
):
|
|
token = set_current_write_origin(origin)
|
|
try:
|
|
assert is_background_review() is expected, (
|
|
f"is_background_review() wrong for origin={origin!r}"
|
|
)
|
|
finally:
|
|
reset_current_write_origin(token)
|
|
|
|
|
|
def test_empty_origin_falls_back_to_foreground():
|
|
from tools.skill_provenance import (
|
|
set_current_write_origin,
|
|
reset_current_write_origin,
|
|
get_current_write_origin,
|
|
)
|
|
token = set_current_write_origin("")
|
|
try:
|
|
# Empty is coerced to "foreground" at the set() boundary.
|
|
assert get_current_write_origin() == "foreground"
|
|
finally:
|
|
reset_current_write_origin(token)
|
|
|
|
|
|
def test_context_isolation_between_copies():
|
|
"""ContextVar scoping: modifications in one copy do not leak out."""
|
|
from tools.skill_provenance import (
|
|
set_current_write_origin,
|
|
get_current_write_origin,
|
|
BACKGROUND_REVIEW,
|
|
)
|
|
|
|
# Start at the module default.
|
|
original = get_current_write_origin()
|
|
|
|
def _run_in_copy():
|
|
set_current_write_origin(BACKGROUND_REVIEW)
|
|
return get_current_write_origin()
|
|
|
|
ctx = contextvars.copy_context()
|
|
inside = ctx.run(_run_in_copy)
|
|
assert inside == BACKGROUND_REVIEW
|
|
# Parent context unaffected.
|
|
assert get_current_write_origin() == original
|