mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
130 lines
4.2 KiB
Python
130 lines
4.2 KiB
Python
"""Tests for the process_loop RuntimeWarning fix -- issue #19285.
|
|
|
|
In Python 3.10+, calling asyncio.get_event_loop() from a non-main thread
|
|
that has no current event loop emits a DeprecationWarning (3.10/3.11) or
|
|
RuntimeWarning (3.12+). The fix replaces get_event_loop() with
|
|
get_running_loop(), which raises RuntimeError (no warning) when there is no
|
|
running loop.
|
|
"""
|
|
|
|
import asyncio
|
|
import threading
|
|
import warnings
|
|
|
|
|
|
class TestGetRunningLoopReplacement:
|
|
|
|
def test_get_running_loop_raises_runtime_error_not_warning(self):
|
|
warnings_caught = []
|
|
|
|
def _thread_target():
|
|
with warnings.catch_warnings(record=True) as w:
|
|
warnings.simplefilter("always")
|
|
try:
|
|
asyncio.get_running_loop()
|
|
except RuntimeError:
|
|
pass
|
|
warnings_caught.extend(w)
|
|
|
|
t = threading.Thread(target=_thread_target, daemon=True)
|
|
t.start()
|
|
t.join(timeout=5)
|
|
|
|
runtime_warnings = [
|
|
x for x in warnings_caught
|
|
if issubclass(x.category, RuntimeWarning)
|
|
]
|
|
assert runtime_warnings == [], (
|
|
f"Unexpected RuntimeWarning(s): {[str(w.message) for w in runtime_warnings]}"
|
|
)
|
|
|
|
def test_get_running_loop_is_silent_get_event_loop_is_not(self):
|
|
caught_from_running = []
|
|
|
|
def _test_get_running_loop():
|
|
with warnings.catch_warnings(record=True) as w:
|
|
warnings.simplefilter("always")
|
|
try:
|
|
asyncio.get_running_loop()
|
|
except RuntimeError:
|
|
pass
|
|
caught_from_running.extend(w)
|
|
|
|
t = threading.Thread(target=_test_get_running_loop, daemon=True)
|
|
t.start()
|
|
t.join(timeout=5)
|
|
|
|
assert all(
|
|
not issubclass(w.category, RuntimeWarning)
|
|
for w in caught_from_running
|
|
), "get_running_loop() must never emit RuntimeWarning"
|
|
|
|
def test_get_running_loop_returns_loop_when_running(self):
|
|
async def _check():
|
|
loop = asyncio.get_running_loop()
|
|
assert loop is not None
|
|
assert loop.is_running()
|
|
|
|
asyncio.run(_check())
|
|
|
|
def test_no_warning_from_background_thread_with_fix(self):
|
|
warnings_caught = []
|
|
|
|
def _thread_target():
|
|
with warnings.catch_warnings(record=True) as w:
|
|
warnings.simplefilter("always")
|
|
try:
|
|
current_loop = asyncio.get_running_loop()
|
|
except RuntimeError:
|
|
current_loop = None
|
|
except Exception:
|
|
current_loop = None
|
|
assert current_loop is None
|
|
warnings_caught.extend(w)
|
|
|
|
t = threading.Thread(target=_thread_target, daemon=True)
|
|
t.start()
|
|
t.join(timeout=5)
|
|
|
|
runtime_warnings = [
|
|
x for x in warnings_caught
|
|
if issubclass(x.category, RuntimeWarning)
|
|
]
|
|
assert runtime_warnings == [], (
|
|
f"RuntimeWarning emitted despite fix: "
|
|
f"{[str(w.message) for w in runtime_warnings]}"
|
|
)
|
|
|
|
def test_fixed_pattern_in_process_loop_context(self):
|
|
results = {}
|
|
warnings_list = []
|
|
|
|
def _process_loop_simulation():
|
|
with warnings.catch_warnings(record=True) as w:
|
|
warnings.simplefilter("always")
|
|
try:
|
|
current_loop = asyncio.get_running_loop()
|
|
except RuntimeError:
|
|
current_loop = None
|
|
except Exception:
|
|
current_loop = None
|
|
results["current_loop"] = current_loop
|
|
warnings_list.extend(w)
|
|
|
|
t = threading.Thread(
|
|
target=_process_loop_simulation,
|
|
name="Thread-3 (process_loop)",
|
|
daemon=True,
|
|
)
|
|
t.start()
|
|
t.join(timeout=5)
|
|
|
|
assert results.get("current_loop") is None
|
|
runtime_warnings = [
|
|
x for x in warnings_list
|
|
if issubclass(x.category, RuntimeWarning)
|
|
]
|
|
assert runtime_warnings == [], (
|
|
f"process_loop simulation still emits RuntimeWarning: "
|
|
f"{[str(w.message) for w in runtime_warnings]}"
|
|
)
|