mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
43 lines
1.4 KiB
Python
43 lines
1.4 KiB
Python
"""Tests for utils.atomic_yaml_write — crash-safe YAML file writes."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
import yaml
|
|
|
|
from utils import atomic_yaml_write
|
|
|
|
|
|
class TestAtomicYamlWrite:
|
|
def test_writes_valid_yaml(self, tmp_path):
|
|
target = tmp_path / "data.yaml"
|
|
data = {"key": "value", "nested": {"a": 1}}
|
|
|
|
atomic_yaml_write(target, data)
|
|
|
|
assert yaml.safe_load(target.read_text(encoding="utf-8")) == data
|
|
|
|
def test_cleans_up_temp_file_on_baseexception(self, tmp_path):
|
|
class SimulatedAbort(BaseException):
|
|
pass
|
|
|
|
target = tmp_path / "data.yaml"
|
|
original = {"preserved": True}
|
|
target.write_text(yaml.safe_dump(original), encoding="utf-8")
|
|
|
|
with patch("utils.yaml.dump", side_effect=SimulatedAbort):
|
|
with pytest.raises(SimulatedAbort):
|
|
atomic_yaml_write(target, {"new": True})
|
|
|
|
tmp_files = [f for f in tmp_path.iterdir() if ".tmp" in f.name]
|
|
assert len(tmp_files) == 0
|
|
assert yaml.safe_load(target.read_text(encoding="utf-8")) == original
|
|
|
|
def test_appends_extra_content(self, tmp_path):
|
|
target = tmp_path / "data.yaml"
|
|
|
|
atomic_yaml_write(target, {"key": "value"}, extra_content="\n# comment\n")
|
|
|
|
text = target.read_text(encoding="utf-8")
|
|
assert "key: value" in text
|
|
assert "# comment" in text
|